Add recurring meeting option to meetings #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 5, 2019
db/migrate/20190416205100_add_closing_add_reminder_dates_to_event_signup.rb
Outdated
Show resolved
Hide resolved
db/migrate/20190416205000_add_closing_user_notification_settings.rb
Outdated
Show resolved
Hide resolved
navro
reviewed
May 6, 2019
navro
reviewed
May 6, 2019
navro
reviewed
May 6, 2019
navro
reviewed
May 6, 2019
navro
reviewed
May 6, 2019
db/migrate/20190410192700_add_recurring_meetings_to_meetings.rb
Outdated
Show resolved
Hide resolved
navro
reviewed
May 6, 2019
navro
reviewed
May 6, 2019
davidkrantz
force-pushed
the
david-recurring-meetings
branch
from
d9c9ef3 to
6dc3d79
Compare
houndci-bot
reviewed
Jun 6, 2019
navro
previously approved these changes
Jul 15, 2019
There was a problem hiding this comment.
You can merge this if you want.
I find It difficult to review the MeetingService, but I trust that you have tested it enough manually.
The rest looks good.
It would be nice with some rspec tests, but I understand if you don't want to write them ;)
Perhaps you can add one for the timezones/daylight saving like we discussed this Saturday. But that can be in a new PR if you wish.
davidkrantz
force-pushed
the
david-recurring-meetings
branch
from
6dc3d79 to
ba5e491
Compare
houndci-bot
reviewed
Jul 27, 2019
davidkrantz
force-pushed
the
david-recurring-meetings
branch
from
ba5e491 to
9023047
Compare
houndci-bot
reviewed
Jul 28, 2019
davidkrantz
force-pushed
the
david-recurring-meetings
branch
from
9023047 to
2c334a4
Compare
houndci-bot
reviewed
Jul 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the long awaited feature to repeat meetings. Also, closes #921.
When creating a new meeting using the admin form (only admins can create recurring meetings), the user can now set how many days there should be between each meeting and also how many times it should occur.
Once a recurring meeting has been created, one may choose to edit the selected meeting, the selected and the meetings after or all meetings. The way a
Meetingis connected to itsRecurringMeetingwhen edited is furthermore based on Google calendar's implementation of recurring events.