Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Canvas2d Layer proposal to support filters. #30

Merged
merged 4 commits into from
Sep 29, 2022

Conversation

graveljp
Copy link
Collaborator

No description provided.

@graveljp graveljp marked this pull request as draft September 28, 2022 18:35
@graveljp graveljp marked this pull request as ready for review September 28, 2022 18:36
@fserb fserb requested review from Juanmihd and fserb September 28, 2022 21:48
Copy link

@Kaiido Kaiido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this moving again.
I left a few suggested edits that only deal with the few typos I found while reading the changes, I hope it's fine with everyone.
I'll leave my comments about the main design in other issues when it's time.

@fserb fserb merged commit b5da576 into fserb:master Sep 29, 2022
@graveljp graveljp deleted the layer-filter-proposal branch September 29, 2022 19:58
@tomayac
Copy link

tomayac commented Sep 30, 2022

Sorry, but it wasn’t clear to me: Will this still support CanvasFilter?

@fserb
Copy link
Owner

fserb commented Sep 30, 2022

Yes. Sorry it wasn't clear. We are going to give a bit more context on the WhatWG issue next week. But this was agreed between the browsers as the proper way to surface CanvasFilter.

@graveljp
Copy link
Collaborator Author

This is already covered in this pull request:

"Filters can be specified as a string parsable as a <filter-value-list>, or as a CanvasFilter object (when that proposal lands)."

I said "when that proposal lands", because as of right now, the CanvasFilter proposal has been reverted from the specification. See discussion in whatwg/html#5621 and revert CL at whatwg/html@c7ad099. The main objections were around the use of ctx.filter, which has never reached consensus. This new beginLayer proposal should resolve these concerns.

@tomayac
Copy link

tomayac commented Sep 30, 2022

Brilliant, thanks for clarifying! Glad CanvasFilter has found a new home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants