-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Canvas2d Layer proposal to support filters. #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see this moving again.
I left a few suggested edits that only deal with the few typos I found while reading the changes, I hope it's fine with everyone.
I'll leave my comments about the main design in other issues when it's time.
Sorry, but it wasn’t clear to me: Will this still support |
Yes. Sorry it wasn't clear. We are going to give a bit more context on the WhatWG issue next week. But this was agreed between the browsers as the proper way to surface CanvasFilter. |
This is already covered in this pull request: "Filters can be specified as a string parsable as a <filter-value-list>, or as a CanvasFilter object (when that proposal lands)." I said "when that proposal lands", because as of right now, the CanvasFilter proposal has been reverted from the specification. See discussion in whatwg/html#5621 and revert CL at whatwg/html@c7ad099. The main objections were around the use of |
Brilliant, thanks for clarifying! Glad |
No description provided.