-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make reuse init reuse info present in pyproject.toml #345
base: main
Are you sure you want to change the base?
Conversation
See PEP 621 for the spec: https://www.python.org/dev/peps/pep-0621/
In dev toml was installed as an implicit dependency from one of the tools, but the Docker build failed.
Seems to be a good idea. I think this needs some coordination with #240 which focuses more on version control being the source for author details. |
Maybe the invoker of reuse should be considered as the source of truth (author and user in vcs aren't always copyright holder either... Anything googlers make is owned by Google, for instance) and should reuse just collect all possible values from all sources and present them as possible defaults. Much like pdm init presents all python executables it can find, and asks which one to use and store in the config. |
@CharString I took a look at
Considering that the output of |
@nicorikken Yes, that's the idea. About saving the choices. I'm very new to What do you think? |
Great. About saving it, that would only make sens if you'd run it often. For example each git commit, or in a continuous integration process. I'm not sure if anybody is doing something like that. You could always provide explicit parameters to the So thinking about it know, I think an interactive selection would be nice if multiple options are encountered (like in this PR and #240 ). And saving it could be a future extension. Regarding this specific PR, I'm not a REUSE maintainer, so it's not my call. I like the idea in general. This of course could grow to many types of project files, so we'd just have to make sure this is worth adding. |
The current line of thought is not to bloat REUSE with all sort of configuration options and suggest helper scripts instead: https://reuse.readthedocs.io/en/latest/scripts.html Perhaps instead of this pull request we can come up with a oneliner or small script to read author information from the pyproject.toml? |
I was using reuse on an existing project and was surprised
reuse init
didn't use the info from pyproject.toml, so I wrote a patch.See PEP 621 for the spec:
https://www.python.org/dev/peps/pep-0621/