-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Proj-Info and FCS to support F# 6 and .Net 6 #846
Conversation
Carries on from #825 |
b0f3a1e
to
00518b0
Compare
10 tests failing on macos/ubuntu, and those are mostly the go-to-def tests. Window's tests are horked, possibly due to script project options discovery? |
This seems to be working under manual testing, but the automated tests are (largely) failing due to typeload exceptions in msbuild. I believe this is due to the hosting model the tests use - instead of testing out-of-process spawned FSAC instances at the LSP level, we have a project-level reference, and then dlls are xcopied, etc, etc. It's a mess. Therefore, given the imminent release of F# 6 and .Net 6, I propose the following set of steps:
|
…sults can be looked up
This is starting to look really good. I figured out a couple core problems with how project options were being generated/modified in ways that got them out of sync with the project options used as keys in certain compiler caches, and as soon as I fixed those a lot of the inability to find parse and check results went away. Then it's been a matter of chipping away at implementation details and differences between FCS 39 and 41. There are roughly 15 tests still failing, and they fall into the following categories:
I'd like to try to solve the rename and find references testing issues before release, and of course do manual testing (@Krzysztof-Cieslak and I have had various issues with scripts when testing this work locally that doesn't align with the overall successful test runs here). |
We've done manual testing, and we're happy with the state of this. Work will need to be done subsequently to green up the rename and find references features, but we feel that supporting F# 6 and .Net 6 more correctly is worth the loss of those features for a short amount of time. |
@baronfel A huge thanks for your work on this! Good job! 👏🏻🔷🚀 |
No description provided.