Skip to content

FCS should unsubscribe from TP Invalidate events when disposing builders #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dsyme opened this issue Jun 11, 2014 · 3 comments
Closed

FCS should unsubscribe from TP Invalidate events when disposing builders #159

dsyme opened this issue Jun 11, 2014 · 3 comments

Comments

@dsyme
Copy link
Contributor

dsyme commented Jun 11, 2014

See this comment: #158 (comment)

We should unsubscribe from the Invalidate event and/or use a weak reference, to reduce the impact of leaks like this: https://github.com/fsharp/FSharp.Compiler.Service/blob/master/src/fsharp/build.fs#L4091
@quasilord
Copy link
Contributor

I have a fix for this

@quasilord
Copy link
Contributor

Update: This alone doesn't give any protection against memory leaks because the TypeProviderConfig object given to the type provider still captures the FCS resources.

The real solution is that the type provider should dispose of things properly.

quasilord added a commit that referenced this issue Jun 11, 2014
@quasilord
Second half of fix for #159
4e7c8bc
@quasilord
Copy link
Contributor

Updated fix published in FCS 0.0.54

ctaggart pushed a commit to ctaggart/FSharp.Compiler.Service that referenced this issue Jul 2, 2014
@dsyme
Merge pull request fsharp#159 from knocte/3.0.30
0041d3a 
Proper DESTDIR support (very useful for making custom deb/rpm packages)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quasilord @dsyme