GetAllUsesOfAllSymbolsInFile returns wrong FSharpSymbolUse for extension properties

[vasily-kirichenko]

For code

module Module =
    type System.String with
        member __.ExtensionProperty = ()
open Module
let _ = "a long string".ExtensionProperty

CheckFileResults.GetAllUsesOfAllSymbolsInFile returns the following FSharpSymbolUse for ExtensionProperty in the last line:

The wrong things are:

• FullName is "System.String.ExtensionProperty" (instead of "SourceCodeClassifierTests.Module.ExtensionProperty" as it is for line 4, when it's defined)
• RangeAlternate covers the property itself and "a long string" value altogether (instead of 6, 24; 6, 41 it's 6, 8; 6, 41).

All these blocks me to finish "Gray out unused open declaration" VFPT feature fsprojects-archive/zzarchive-VisualFSharpPowerTools#574 because I cannot determine that open Module is actually used by line let _ = "a long string".ExtensionProperty.

[dungpa]

FCS returns correct results for extension members. This issue only occurs on extension properties. It might be an oversight due to FCS' recent changes in property handling. Please help us to fix this.

[vasily-kirichenko]

Please tell us this can be fixed in theory. If not, we continue hacking our really ugly workaround.

//cc @dsyme

[dungpa]

EnclosingEntity of ExtensionProperty symbol mistakenly points to System.String type. I think it should point to Module module in the same way that the symbol at the definition of ExtensionProperty does.

[dsyme]

All this looks fixable, at least in theory :)

[dungpa]

If we are able to retrieve getter methods and setter methods from properties i.e. #191, it will make the weirdness of property symbols more tolerable.