Skip to content

FsiEvaluationSession.EvalExpression exception and error handling #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Jan 11, 2014 · 2 comments
Closed

FsiEvaluationSession.EvalExpression exception and error handling #19

ghost opened this issue Jan 11, 2014 · 2 comments
Labels
added value

Comments

@ghost
Copy link

ghost commented Jan 11, 2014

EvalExpression and EvalInteraction need to have better specified exception behaviour

  • Return ErrorInfo[] for warnings and errors from parsing and typechecking
  • Directly raise exceptions from execution (preferably without losing the callstack)
@forki
Copy link
Member

forki commented Jun 24, 2014

I could use this in https://github.com/fsharp/FAKE/blob/master/src/app/FakeLib/FSIHelper.fs#L118 too

@dsyme dsyme closed this as completed in ae66aaf Jul 31, 2015
@rneatherway rneatherway reopened this Jul 31, 2015
@dsyme
Copy link
Contributor

dsyme commented Dec 2, 2015

Fixed by #475

@dsyme dsyme closed this as completed Dec 2, 2015
baronfel pushed a commit to baronfel/FSharp.Compiler.Service that referenced this issue Sep 30, 2019
@brettfo
IMAGE_DEBUG_TYPE_CHECKSUMPDB version in pdb writer (#7443) (#7444)
0422ff2 
F# Compiler is emitting the incorrect minor version number for Debug Directory entry type fsharp#19 (PDB Checksum). This bug seems like either a copy/paste error or human error. 0x0100 is the correct minor version number for embedded pdb info, but 0 is the correct minor version number for pdb checksum as spec'd here: https://github.com/dotnet/corefx/blob/master/src/System.Reflection.Metadata/specs/PE-COFF.md#pdb-checksum-debug-directory-entry-type-19

This issues causes the VS Debugger to ignore PDB Checksum entries in F# pdbs, which breaks NuGet.org Symbol Server scenarios for F#.
baronfel pushed a commit to baronfel/FSharp.Compiler.Service that referenced this issue Sep 30, 2019
@chuckries @baronfel
IMAGE_DEBUG_TYPE_CHECKSUMPDB version in pdb writer (#7443)
1e6fb85 
F# Compiler is emitting the incorrect minor version number for Debug Directory entry type fsharp#19 (PDB Checksum). This bug seems like either a copy/paste error or human error. 0x0100 is the correct minor version number for embedded pdb info, but 0 is the correct minor version number for pdb checksum as spec'd here: https://github.com/dotnet/corefx/blob/master/src/System.Reflection.Metadata/specs/PE-COFF.md#pdb-checksum-debug-directory-entry-type-19

This issues causes the VS Debugger to ignore PDB Checksum entries in F# pdbs, which breaks NuGet.org Symbol Server scenarios for F#.
baronfel pushed a commit to baronfel/FSharp.Compiler.Service that referenced this issue Nov 9, 2019
@chuckries @brettfo
IMAGE_DEBUG_TYPE_CHECKSUMPDB version in pdb writer (#7443)
168e150 
F# Compiler is emitting the incorrect minor version number for Debug Directory entry type fsharp#19 (PDB Checksum). This bug seems like either a copy/paste error or human error. 0x0100 is the correct minor version number for embedded pdb info, but 0 is the correct minor version number for pdb checksum as spec'd here: https://github.com/dotnet/corefx/blob/master/src/System.Reflection.Metadata/specs/PE-COFF.md#pdb-checksum-debug-directory-entry-type-19

This issues causes the VS Debugger to ignore PDB Checksum entries in F# pdbs, which breaks NuGet.org Symbol Server scenarios for F#.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
added value
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@forki @rneatherway @quasilord @dsyme