Skip to content

FCS makes calls to kernel32.dll when running on OSX #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nosami opened this issue Nov 3, 2015 · 2 comments
Closed

FCS makes calls to kernel32.dll when running on OSX #456

nosami opened this issue Nov 3, 2015 · 2 comments

Comments

@nosami
Copy link
Member

nosami commented Nov 3, 2015

https://github.com/fsharp/FSharp.Compiler.Service/blob/c1ca06144d8194000cf6b86f5f26bdc433ccaa7d/src/absil/ilread.fs#L169

screen shot 2015-11-03 at 15 08 51
@7sharp9
Copy link
Member

7sharp9 commented Nov 3, 2015

Ive notices this a lot too, Its detrimental to performance on the x-plat compiler and tools.

@dsyme
Copy link
Contributor

dsyme commented Nov 4, 2015

If possible please submit a PR to change this throw-and-catch to a conditional that detects whether we are running on Windows: https://github.com/fsharp/FSharp.Compiler.Service/blob/master/src/absil/ilread.fs#L3977

nosami added a commit to nosami/FSharp.Compiler.Service that referenced this issue Nov 4, 2015
@nosami
Change try/catch to conditional. fixes fsharp#456
9c8147f
nosami added a commit to nosami/FSharp.Compiler.Service that referenced this issue Nov 4, 2015
@nosami
Change try/catch to conditional. fixes fsharp#456
043ba16
@dsyme dsyme closed this as completed in 35d2e52 Nov 5, 2015
dsyme added a commit that referenced this issue Nov 5, 2015
@dsyme
Merge pull request #457 from nosami/conditional-memory-mapped-files
3291102 
Change throw/catch to conditional. fixes #456
matthid pushed a commit to matthid/FSharp.Compiler.Service that referenced this issue Nov 8, 2015
@dsyme
Merge pull request fsharp#456 from ctaggart/nuspec
c3aaf7d 
added trailing 0 for Xamarin + Paket compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@7sharp9 @nosami @dsyme