Skip to content

Add IsLiteral/LiteralValue to FSharpField #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2014
Merged

Add IsLiteral/LiteralValue to FSharpField #207

merged 1 commit into from
Sep 1, 2014

Conversation

7sharp9
Copy link
Member

@7sharp9 7sharp9 commented Aug 29, 2014

Also updated corresponding tests
Fixes #197

Also updated corresponding tests
Fixes #197
@dungpa
Copy link
Contributor

dungpa commented Aug 31, 2014

Look good to me. +1 for adding this.

7sharp9 added a commit that referenced this pull request Sep 1, 2014
Add IsLiteral/LiteralValue to FSharpField
@7sharp9 7sharp9 merged commit fffa322 into fsharp:master Sep 1, 2014
@OkayX6
Copy link
Contributor

OkayX6 commented Sep 1, 2014

Great! I wasn't really aware that @7sharp9 was one of the project admins :)!

@7sharp9
Copy link
Member Author

7sharp9 commented Sep 1, 2014

I dont like to merge my own changes but it looks like its a quiet here lately.

@OkayX6
Copy link
Contributor

OkayX6 commented Sep 1, 2014

Hehe. Do you also have the power to release new NuGet packages? ;)

@7sharp9
Copy link
Member Author

7sharp9 commented Sep 1, 2014

I do, although Im not sure I remember the release process.

I was hoping to get the test done for #182 and include that in the release too.

@dsyme
Copy link
Contributor

dsyme commented Sep 1, 2014

Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IsLiteral / LiteralValue to FSharpField so that Enum tooltips in XS can have the literal values rendered.
4 participants