Implements FSharpMemberOrFunctionOrValue.IsConstructorThisValue, IsMemberThisValue & LiteralValue #375
Conversation
| if isUnresolved() then false else | ||
| match d with | ||
| | M _ | P _ | E _ -> false | ||
| | V v -> match v.BaseOrThisInfo with CtorThisVal -> true | _ -> false |
There was a problem hiding this comment.
Could be shortened to v.BaseOrThisInfo = CtorThisVal.
|
Looks good. It would be great to fix the failing test if it's meant to be a part of the changes. |
|
Thanks a lot for your useful comments, @dungpa! I've fixed the PR. You're right about the overloads (I had a look at the issue, but unfortunately my limited knowledge of the project didn't get me too far), so I deleted the test. About walking the typed tree in the tests, I'm using the compiler services for FunScript where I'm accessing the symbols mostly through the AST and, as I've found some disagreements when you retrieve a symbol via the AST or something like Cheers! |
|
Great jobs. Thanks a lot. I'm not aware that anyone uses typed tree API extensively. There are probably inconsistencies to iron out. |
Implements FSharpMemberOrFunctionOrValue.IsConstructorThisValue, IsMemberThisValue & LiteralValue
I didn't implement IsBaseValue, because I couldn't find a case where you can get a
basereference without usingBasicPatterns.BaseValueactive pattern (which doesn't include aFSharpMemberOrFunctionOrValuevalue).Also adds some tests for these properties and for the
FSharpMemberOrFunctionOrValue.Overloads. The latter doesn't pass at the moment, see #356.Can you please review the PR? Cheers!