Use Paket to create Nuget packages #462

forki · 2015-11-10T19:06:55Z

implements #461

nosami · 2015-11-10T19:19:09Z

I get the following error when trying to run the new task on OSX

mono  /Users/jason/src/fsharp/FSharp.Compiler.Service/.paket/paket.exe pack output ./temp  version  1.4.2.1 releaseNotes  "#450 - Correct generation of ReferencedProjects"
Paket version 2.23.2.0
Unable to parse /Users/jason/src/fsharp/FSharp.Compiler.Service/tests/service/data/Malformed.fsproj:
      Data at the root level is invalid. Line 1, position 1.
Paket failed with:
    The file "../bin/v4.0/FSharp.Compiler.Service.xml" requested in /Users/jason/src/fsharp/FSharp.Compiler.Service/nuget/paket.template does not exist.
Running build failed.
Error:
System.Exception: Error during packing ..
  at Fake.Paket+Pack@78.Invoke (System.String message) <0x9cbac70 + 0x00027> in <filename unknown>:0
  at Microsoft.FSharp.Core.PrintfImpl+StringPrintfEnv`1[TResult].Finalize () <0x3078f50 + 0x00030> in <filename unknown>:0
  at Microsoft.FSharp.Core.PrintfImpl+Final1@224[TState,TResidue,TResult,A].Invoke (Microsoft.FSharp.Core.FSharpFunc`2 env, A a) <0x3078d10 + 0x00085> in <filename unknown>:0
  at Microsoft.FSharp.Core.OptimizedClosures+Invoke@3253[T2,TResult,T1].Invoke (T2 u) <0x3078ce8 + 0x00024> in <filename unknown>:0
  at Fake.Paket.Pack (Microsoft.FSharp.Core.FSharpFunc`2 setParams) <0x9cb6000 + 0x0039a> in <filename unknown>:0
  at FSI_0001.Build+clo@137-16.Invoke (Microsoft.FSharp.Core.Unit _arg9) <0x891ff50 + 0x0001b> in <filename unknown>:0
  at Fake.TargetHelper+targetFromTemplate@155[a].Invoke (Microsoft.FSharp.Core.Unit unitVar0) <0x9cabf38 + 0x00020> in <filename unknown>:0
  at Fake.TargetHelper.runSingleTarget (Fake.TargetTemplate`1 target) <0x9ca36e8 + 0x000bd> in <filename unknown>:0

forki · 2015-11-10T19:29:38Z

Yes. One of the unittest data files is conflicting ;-)

I'm trying to work around that
On Nov 10, 2015 20:19, "Jason Imison" notifications@github.com wrote:

I get the following error when trying to run the new task on OSX

mono /Users/jason/src/fsharp/FSharp.Compiler.Service/.paket/paket.exe pack output ./temp version 1.4.2.1 releaseNotes "#450 - Correct generation of ReferencedProjects"
Paket version 2.23.2.0
Unable to parse /Users/jason/src/fsharp/FSharp.Compiler.Service/tests/service/data/Malformed.fsproj:
Data at the root level is invalid. Line 1, position 1.
Paket failed with:
The file "../bin/v4.0/FSharp.Compiler.Service.xml" requested in /Users/jason/src/fsharp/FSharp.Compiler.Service/nuget/paket.template does not exist.
Running build failed.
Error:
System.Exception: Error during packing ..
at Fake.Paket+Pack@78.Invoke (System.String message) <0x9cbac70 + 0x00027> in :0
at Microsoft.FSharp.Core.PrintfImpl+StringPrintfEnv1[TResult].Finalize () <0x3078f50 + 0x00030> in <filename unknown>:0 at Microsoft.FSharp.Core.PrintfImpl+Final1@224[TState,TResidue,TResult,A].Invoke (Microsoft.FSharp.Core.FSharpFunc2 env, A a) <0x3078d10 + 0x00085> in :0
at Microsoft.FSharp.Core.OptimizedClosures+Invoke@3253[T2,TResult,T1].Invoke (T2 u) <0x3078ce8 + 0x00024> in :0
at Fake.Paket.Pack (Microsoft.FSharp.Core.FSharpFunc2 setParams) <0x9cb6000 + 0x0039a> in <filename unknown>:0 at FSI_0001.Build+clo@137-16.Invoke (Microsoft.FSharp.Core.Unit _arg9) <0x891ff50 + 0x0001b> in <filename unknown>:0 at Fake.TargetHelper+targetFromTemplate@155[a].Invoke (Microsoft.FSharp.Core.Unit unitVar0) <0x9cabf38 + 0x00020> in <filename unknown>:0 at Fake.TargetHelper.runSingleTarget (Fake.TargetTemplate1 target) <0x9ca36e8 + 0x000bd> in :0

—
Reply to this email directly or view it on GitHub
#462 (comment)
.

… fsproj files as test data

nosami · 2015-11-10T19:40:25Z

The file "../bin/v4.0/FSharp.Compiler.Service.xml" requested in /Users/jason/src/fsharp/FSharp.Compiler.Service/nuget/paket.template does not exist.

forki · 2015-11-10T19:42:51Z

and is it really not there?

nosami · 2015-11-10T19:43:35Z

ah.. it's FSharp.Compiler.Service.XML. Capital XML :)

forki · 2015-11-10T19:44:18Z

thx. will fix.
hope the travis build will find that too

forki · 2015-11-10T19:46:24Z

ah nuget target is disabled for travis. will enable first to see it fail. I mean we want to make it x-plat...

forki · 2015-11-10T20:01:05Z

Ok Travis found the issue in 7c9aaec. 0ac89b9 hopefully gets green

forki · 2015-11-10T20:09:29Z

@nosami now it's complaining about the pdb. do you see the error?

forki · 2015-11-10T20:10:22Z

let me guess the mono build doesn't create pdbs

nosami · 2015-11-10T20:16:11Z

Got it! .mdb files are the equivalent

forki · 2015-11-10T20:19:02Z

bde41f1 should just add ?db files

nosami · 2015-11-10T20:22:49Z

Needs to be FSharp.Compiler.Service.dll.mdb

forki · 2015-11-11T08:22:44Z

I think it's ready to merge

nosami · 2015-11-11T12:20:45Z

Works for me

✔ ~/src/fsharp/FSharp.Compiler.Service/bin [paketpack ↓·1|✔]
12:19 $ l
total 18880
drwxr-xr-x   5 jason  staff      170 10 Nov 21:22 .
drwxr-xr-x  30 jason  staff     1020 10 Nov 21:22 ..
-rw-r--r--   1 jason  staff  9664085 10 Nov 21:22 FSharp.Compiler.Service.1.4.2.1.nupkg
drwxr-xr-x  27 jason  staff      918 10 Nov 21:18 v4.0
drwxr-xr-x  27 jason  staff      918 10 Nov 21:19 v4.5

forki · 2015-11-11T12:25:11Z

did you take a look into the nupkg?

2015-11-11 13:20 GMT+01:00 Jason Imison notifications@github.com:

Works for me

✔ ~/src/fsharp/FSharp.Compiler.Service/bin [paketpack ↓·1|✔]
12:19 $ l
total 18880
drwxr-xr-x 5 jason staff 170 10 Nov 21:22 .
drwxr-xr-x 30 jason staff 1020 10 Nov 21:22 ..
-rw-r--r-- 1 jason staff 9664085 10 Nov 21:22 FSharp.Compiler.Service.1.4.2.1.nupkg
drwxr-xr-x 27 jason staff 918 10 Nov 21:18 v4.0
drwxr-xr-x 27 jason staff 918 10 Nov 21:19 v4.5

—
Reply to this email directly or view it on GitHub
#462 (comment)
.

nosami · 2015-11-11T12:28:35Z

12:28 $ tree
.
├── FSharp.Compiler.Service.nuspec
├── [Content_Types].xml
├── _rels
├── lib
│   ├── net40
│   │   ├── FSharp.Compiler.Service.XML
│   │   ├── FSharp.Compiler.Service.dll
│   │   └── FSharp.Compiler.Service.dll.mdb
│   └── net45
│       ├── FSharp.Compiler.Service.XML
│       ├── FSharp.Compiler.Service.dll
│       └── FSharp.Compiler.Service.dll.mdb
└── package
    └── services
        └── metadata
            └── core-properties
                └── coreProp.psmdcp

8 directories, 9 files

forki · 2015-11-11T12:32:13Z

yeah and the nuspec looked also good

nosami · 2015-11-11T12:32:49Z

<?xml version="1.0" encoding="utf-8" standalone="yes"?>
<package xmlns="http://schemas.microsoft.com/packaging/2011/10/nuspec.xsd">
  <metadata>
    <id>FSharp.Compiler.Service</id>
    <version>1.4.2.1</version>
    <authors>Microsoft Corporation, Dave Thomas, Anh-Dung Phan, Tomas Petricek</authors>
    <licenseUrl>https://github.com/fsharp/FSharp.Compiler.Service/blob/master/LICENSE</licenseUrl>
    <projectUrl>https://github.com/fsharp/FSharp.Compiler.Service</projectUrl>
    <iconUrl>https://raw.github.com/fsharp/FSharp.Compiler.Service/master/misc/logo.png</iconUrl>
    <description>The F# compiler services package contains a custom build of the F# compiler that
exposes additional functionality for implementing F# language bindings, additional
tools based on the compiler or refactoring tools. The package also includes F#
interactive service that can be used for embedding F# scripting into your applications.</description>
    <summary>F# compiler services for creating IDE tools, language extensions and for F# embedding.</summary>
    <releaseNotes>#450 - Correct generation of ReferencedProjects</releaseNotes>
    <tags>F# fsharp interactive compiler editor</tags>
  </metadata>
</package>

Use Paket to create Nuget packages

dsyme · 2015-11-11T13:29:25Z

Awesome work guys

dsyme · 2015-12-01T19:04:34Z

Note we started getting unit test failures after this, see https://travis-ci.org/fsharp/FSharp.Compiler.Service/builds. This is caused by CI changing from Mono 4.0.5 to Mono .4.2.1. Urgh.

Errors and Failures:
1) Test Failure : FSharp.Compiler.Service.Tests.ProjectOptionsTests.Project file parsing -- 2nd level references
     Expected: "Found 'Test1.dll'"
Actual: "Failed to find 'Test1.dll'"
  Expected string length 17 but was 26. Strings differ at index 1.
  Expected: "Found 'Test1.dll'"
  But was:  "Failed to find 'Test1.dll'"
  ------------^

at FsUnit.shouldEqual[a] (a x, a y) <0x41e11d10 + 0x00143> in <filename unknown>:0
at FSharp.Compiler.Service.Tests.ProjectOptionsTests.checkOption (System.String[] opts, System.String s) <0x426e8a40 + 0x00128> in <filename unknown>:0
at FSharp.Compiler.Service.Tests.ProjectOptionsTests.Project file parsing -- 2nd level references () <0x426e8670 + 0x00180> in <filename unknown>:0

2) Test Failure : FSharp.Compiler.Service.Tests.ProjectOptionsTests.Project file parsing -- multi language project
     Expected: "Found 'ConsoleApplication2.exe'"
Actual: "Failed to find 'ConsoleApplication2.exe'"
  Expected string length 31 but was 40. Strings differ at index 1.
  Expected: "Found 'ConsoleApplication2.exe'"
  But was:  "Failed to find 'ConsoleApplication2.exe'"
  ------------^

at FsUnit.shouldEqual[a] (a x, a y) <0x41e11d10 + 0x00143> in <filename unknown>:0
at FSharp.Compiler.Service.Tests.ProjectOptionsTests.checkOption (System.String[] opts, System.String s) <0x426e8a40 + 0x00128> in <filename unknown>:0
at FSharp.Compiler.Service.Tests.ProjectOptionsTests.Project file parsing -- multi language project () <0x426ee5c0 + 0x0016b> in <filename unknown>:0

3) Test Failure : FSharp.Compiler.Service.Tests.ProjectOptionsTests.Project file parsing -- reference project output file
     Expected: collection containing "/home/travis/build/fsharp/FSharp.Compiler.Service/tests/service/data/DifferingOutputDir/Dir1/OutputDir1/Test1.dll"
  But was:  < "/usr/lib/mono/gac/FSharp.Core/4.3.0.0__b03f5f7f11d50a3a/FSharp.Core.dll", "/usr/lib/mono/4.0/mscorlib.dll", "/usr/lib/mono/4.0/System.dll", "/usr/lib/mono/4.0/System.Core.dll" >

at FsUnit.should[a,a] (Microsoft.FSharp.Core.FSharpFunc`2 f, a x, System.Object y) <0x423e9430 + 0x001f9> in <filename unknown>:0
at FSharp.Compiler.Service.Tests.ProjectOptionsTests.Project file parsing -- reference project output file () <0x426f3480 + 0x00266> in <filename unknown>:0

dsyme · 2015-12-01T19:09:38Z

@forki forget that - the failures are caused by changing from Mono 4.0.5 to Mono 4.2.1

forki · 2015-12-01T19:12:12Z

Unfortunately we have lots of issues with latest mono. FAKE's own build is
flaky now.
On Dec 1, 2015 20:09, "Don Syme" notifications@github.com wrote:

@forki https://github.com/forki forget that - the failures are caused
by changing from Mono 4.0.5 to Mono 4.2.1

—
Reply to this email directly or view it on GitHub
#462 (comment)
.

dsyme · 2015-12-01T19:14:39Z

ok, thanks

Use Paket to create Nuget packages

9f913e3

Only pack a concrete template file since this repo contains malformed…

4e58dc8

… fsproj files as test data

Set outputpath to bin folder

61b04a5

forki added 2 commits November 10, 2015 20:47

Check NuGet package build on travis

7c9aaec

It's capital XML for the NuGet

0ac89b9

forki changed the title ~~WIP: Use Paket to create Nuget packages~~ Use Paket to create Nuget packages Nov 10, 2015

forki mentioned this pull request Nov 10, 2015

Move to paket for nupgk creation #461

Closed

forki force-pushed the paketpack branch from c18f368 to bde41f1 Compare November 10, 2015 20:18

forki force-pushed the paketpack branch 2 times, most recently from 2ded086 to 2714094 Compare November 10, 2015 20:29

On mono we don't create pdbs - so we can't add these

f87a9f7

forki force-pushed the paketpack branch from 2714094 to f87a9f7 Compare November 10, 2015 20:44

Add paket.template to solution

fdea4e1

dsyme added a commit that referenced this pull request Nov 11, 2015

Merge pull request #462 from forki/paketpack

839bab6

Use Paket to create Nuget packages

dsyme merged commit 839bab6 into fsharp:master Nov 11, 2015

dsyme mentioned this pull request Dec 1, 2015

Projects out of process (new api) #470

Merged

Use Paket to create Nuget packages #462

Use Paket to create Nuget packages #462

Uh oh!

Conversation

forki commented Nov 10, 2015

Uh oh!

nosami commented Nov 10, 2015

Uh oh!

forki commented Nov 10, 2015

Uh oh!

nosami commented Nov 10, 2015

Uh oh!

forki commented Nov 10, 2015

Uh oh!

nosami commented Nov 10, 2015

Uh oh!

forki commented Nov 10, 2015

Uh oh!

forki commented Nov 10, 2015

Uh oh!

forki commented Nov 10, 2015

Uh oh!

forki commented Nov 10, 2015

Uh oh!

forki commented Nov 10, 2015

Uh oh!

nosami commented Nov 10, 2015

Uh oh!

forki commented Nov 10, 2015

Uh oh!

nosami commented Nov 10, 2015

Uh oh!

forki commented Nov 11, 2015

Uh oh!

nosami commented Nov 11, 2015

Uh oh!

forki commented Nov 11, 2015

Uh oh!

nosami commented Nov 11, 2015

Uh oh!

forki commented Nov 11, 2015

Uh oh!

nosami commented Nov 11, 2015

Uh oh!

dsyme commented Nov 11, 2015

Uh oh!

dsyme commented Dec 1, 2015

Uh oh!

dsyme commented Dec 1, 2015

Uh oh!

forki commented Dec 1, 2015

Uh oh!

dsyme commented Dec 1, 2015

Uh oh!

Uh oh!