Exposing slot signature of members in object expressions #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm looks like Travis CI is busted - perhaps something to do with using Mono 4.0.5.1 |
|
The change looks good - any chance you could add some tests too? I know you said there weren't any for FSharpObjectExprOverride but please add at least a smoke test for that, along with this new addition. thanks |
|
@dsyme Thanks, I will do this, probably tomorrow. |
|
Thank you for adding the tests |
dsyme
added a commit
that referenced
this pull request
Nov 30, 2015
Exposing slot signature of members in object expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small addition of a
.Signaturemember toFSharpObjectExprOverride. This is needed for identifying the member overridden or implemented.There are no current tests included for
FSharpObjectExprOverrideas I've seen, but I tested this change in a bigger project and it worked correctly.