Skip to content

Make ...Logged have logging be the default #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2015
Merged

Make ...Logged have logging be the default #479

merged 1 commit into from
Dec 2, 2015

Conversation

rneatherway
Copy link
Member

This is more intuitive, and doesn't change the standard behaviour.
Also update remaining references to
checker.GetProjectOptionsFromProjectFile

With these changes I can GenerateDocs on Windows, although not on Mono. On Mono I get:

Compilation errors:
 - warning: (0, 0) Assuming assembly reference `FSharp.Core, Version=4.3.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' matches assembly `FSharp.Core, Version=4.4.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. You may need to supply runtime policy
 - error: (0, 0) Assembly `Microsoft.Build.Utilities.v12.0, Version=12.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' references `Microsoft.Build.Framework, Version=12.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' which has a higher version number than imported assembly `Microsoft.Build.Framework, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'

System.Exception: Generating HTML failed.
  at FSharp.Literate.RazorRender.handleCompile[a] (System.String source, Microsoft.FSharp.Core.FSharpFunc`2 f) <0x40f4ea20 + 0x006a7> in <filename unknown>:0 
  at FSharp.Literate.RazorRender.ProcessFileModel[b] (System.Type modelType, System.Object model, Microsoft.FSharp.Core.FSharpOption`1 properties) <0x40f4e820 + 0x00087> in <filename unknown>:0 
  at FSharp.Literate.Templating.generateFile (Microsoft.FSharp.Core.FSharpOption`1 references, System.String contentTag, IEnumerable`1 parameters, Microsoft.FSharp.Core.FSharpOption`1 templateOpt, System.String output, IEnumerable`1 layoutRoots) <0x40f4b960 + 0x001cb> in <filename unknown>:0 
  at FSharp.Literate.Templating.processFile (Microsoft.FSharp.Core.FSharpOption`1 references, FSharp.Literate.LiterateDocument doc, System.String output, FSharp.Literate.ProcessingContext ctx) <0x40f10cf0 + 0x0043f> in <filename unknown>:0 
...
<snip>

This is more intuitive, and doesn't change the standard behaviour.
Also update remaining references to
checker.GetProjectOptionsFromProjectFile
dsyme added a commit that referenced this pull request Dec 2, 2015
Make ...Logged have logging be the default
@dsyme dsyme merged commit 9ba8aef into fsharp:master Dec 2, 2015
@rneatherway rneatherway deleted the project-cracking-cleanup-api branch December 2, 2015 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants