Integrate from fsharp\fsharp master #641
Conversation
…ualfsharp into jackmott-faster-array-filter
1. Use public sign. 2. fix some slightly irritating indentation. 3. Move release and debug speciffic settings to settings.targets 4. Remove TargetFramework support for platforms that are not part of the OSS build.
* Cleanup Optimizer Thank you for taking care of this. * We don't need to check the lenght here * Don't convert list to array multiple times * Only fold the Flatlist * Optimize FlatList away * Revert code duplication * match => if * cleanup * DevirtualizeApplication doesn't need optimized Expression
…m.Collections.Immutable and others
Integrate Microsoft/visualfsharp --> master
add optdata/sigdata
dsyme
force-pushed
the
integrate-776
branch
from
12644e9 to
909adb8
Compare
|
@ncave @enricosada This integration busts the .NET Core support. I'm trying to work through the issues (first time I've looked closely at FCS support for .NET Core) |
|
Last time I had mono and dnc installed at once it didn't compile. |
|
The most recent FCS builds seem to have some issue with mono:latest (FSharp.Core reference missing, from briefly inspecting the Travis logs), but it may or may not be a different issue. My local mono version is 4.2.3, dnc is 1.0.1 and merged integrate-776 build fine and tests are ok. tl;dr I don't know what's wrong, works on my machine :-| |
|
@ncave I pushed a fix - there was some internal caching behaving incorrectly. One test fails - something to do with multiple StringBuilder types The way we have to scrape the sample project in tests...\Common.fs for a list of default reference assemblies for scripts (and just to get off the ground for projects) is awkward. I suppose we'll have to bake that list into the compiler DLL or synthesize it via another technique |
Yes. This is a different issue though. We need to fix it... |
No description provided.