integrate visualfsharp master and bump version to 17.0.1 #833

dsyme · 2017-11-03T15:25:19Z

No description provided.

Merge master into vs2017-rtm

* Document project options and mark lots of things as deprecated (#3449) * Document project options and mark lots of things as deprecated * delete some code that is no longer used * fix packaging of FSharp.Core. (#3452) * implement IDisposable interfaces explicitly (#3447) * added IDisposable * reverted Dispose change * ngen open source install (#3456) * handle "Blue (high contrast)" theme (#3443)

…o proj1

Merge master to vs2017-rtm

…yme-proj1

merge #3499 into vs2017-rtm

Merge latest master into rtm

…to vs2017-rtm

merge master into vs2017-rtm

* Generate source for .resx files on build. (#3607) * add build task to generate *.fs from *.resx files * generate source for embedded resources in tests * generate source for embedded resources in FSharp.Editor * generate source for embedded resources in FSharp.LanguageService * generate source for embedded resources in FSharp.ProjectSystem.FSharp * generate source for embedded resources in FSharp.VS.FSI * don't generate non-string resources when <=netstandard1.6 * update baseline error message for tests The error output should be the exception message, not the exception type. * perform up-to-date check before generating *.fs from *.resx * remove non-idiomatic fold for an array comprehension * correct newline replacement * output more friendly error message * throw if boolean value isn't explicitly `true` or `false` * only generate object resource code on non `netstandard1.*` and `netcoreapp1.*` platforms * ensure FSharp.Core specifies a target framework for resource generaton * rename attributes to be non-ambiguous and properly include them * fix order of file items in FSharp.Core * Fix build.cmd for certain always-shown errors (like "unable to find registry key"), improve finding of VS2017 tools, fix DEVGUIDE.md (#3635) * Fix build.com displaying the following error on each run "ERROR: The system was unable to find the specified registry key or value." * Remove warning about reg.exe errors introduced in #3614 (in commit b548bd7, but unrelated to that fix), it is no longer necessary. * Fix #3638, VS2017 Preview installation was not found when VS2017RTM is not installed. Remove comment introduced in #3614 (through commit 966bd7f) * Fixing JaroWinkler tests with InvariantCulture and fixing async tests by removing Debugger.Break() (#3627) * Fixing JaroWinkler tests to use InvariantCulture for number-to-string * Fixing the crashing of test runners because of a Debugger.Break() in a test * update to System.Collections.Immutable 1.3.1 (#3641) * update to System.Collections.Immutable 1.3.1 * fixes * fix assembly reference * [WIP] Adds optimized emit for int64 constants (#3620) * Adds optimized emit for int64 constants. * Adds comment linking to the changing PR. Thanks for this PR. Kevin * fix assembly reference (#3646) * Remove a few more build warnings (#3647) * fix assembly reference * remove more build warnings * fix build * move BuildFromSource projects to their own directory * Adds tests for emitted IL for new Int64 constants. (#3650) * Enable FS as prefix and ignore invalid values for warnings (#3631) * enable fs as prefix and ignore invalid values for warnings + tests * Allow #pragma to validate warnings * do it right * use ordinal compare * In both places * Add fs prefix to warnaserror * Fixup tests * Fix stack overflow on assembly resolution (#3658) * Fix stack overflow on tp assembly resolution * Feedback * Add impl files to file check results (#3659) * add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project * add ImplementationFiles to FSharpCheckFileResults * make FSharpImplementationFileContents ctor internal * throw if ImplementationFiles is called having keepAssemblyContents flag set to false * add a test * spelling and cosmetics * This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd (#3672) * This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd * This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd * Remove ambiguous an irrelevant instruction, improved help and instructions * Fix a scenario where the return code wasn't nonzero for error conditions, fixes not creating backup dir when not backing up * add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project (#3657) * bump FCS version (#3676) * bump version * Update RELEASE_NOTES.md * Parsing improvements: no reactor, add parsing options, error severity options (#3601) * Parse without reactor, add parsing options, error severity options * Revert parsing APIs (fallback to the new ones), fix VFT projects * Cache parse results after type check * Add impl files to file check results (#3659) * add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project * add ImplementationFiles to FSharpCheckFileResults * make FSharpImplementationFileContents ctor internal * throw if ImplementationFiles is called having keepAssemblyContents flag set to false * add a test * spelling and cosmetics * This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd (#3672) * This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd * This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd * Remove ambiguous an irrelevant instruction, improved help and instructions * Fix a scenario where the return code wasn't nonzero for error conditions, fixes not creating backup dir when not backing up * add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project (#3657) * bump FCS version (#3676) * bump version * Update RELEASE_NOTES.md * updates to make tests pass * restore old behaviour of CheckFileInProjectAllowingStaleCachedResults (builder had been created by ParseFileInProject) * restore use of CheckFileInProjectAllowingStaleCachedResults * deprecate test relying on whacky behaviour of deprecated GetCheckResultsBeforeFileInProjectEvenIfStale * Use ParseFile and FSharpParsingOptions instead of ParseFileInProject * prepare FCS release with this feature * whitespace cleanup (#3682) * whitespace and docs (#3684) * Preserve XML docs for in-memory project references (#3683) * fix xmldocs for in-memory project references * add test * fix tests * whitespace and comments (#3686) * fix assembly reference * whitespace and comments * whitespace and comments * whitespace and comments * cherry pick two PRs from FCS (#3687) * fix assembly reference * remove line endings from all *.nuspec files * ProjectCracker returns *.fsi files in FSharpProjectOptions.SourceFiles array (in addition to *.fs files, in right order) * ProjectCracker raises exception if ProjectCrackerTool returns non null ProjectCrackerOptions.Error (new field) * fix build on linux * fix a test * slashes * revert slashes * Update FSharp.Compiler.Service.ProjectCracker.nuspec * try to fix travis * try to fix travis * list dependencies * no obsolete pdb in nuget * list dependencies * cherry pick of fsharp/fsharp change * bump FCS version number (#3688) * Update FSharp.Compiler.Service.MSBuild.v12.nuspec * fix FCS nuget on windows * fix-resource (#3690) * Bump FSharp.Compiler.Tools to 4.1.27 and align mono build files (#3693) * ri change from fsharp * fix test * bump FSC tools to 4.1.27 * remove fsharp.core from Mono GAC * align mono directory * fix typo * install back versions with Mono * fix typo * update FCS doc generation (#3694) * update DEVGUIDE to add addiitional steps before running build (#3725) * Split templates out into a seperate vsix (#3720) * merge error * Merge issues

This fixes build issues when older versions of MSBuild are used.

* Add new test; fix run.pl regex and affected tests * Don't suggest variables explicitly marked unused

* undo dotnet/fsharp#3536 * undo dotnet/fsharp#3536

* Do not commit autocompletion on bracket or pipe chars * Remove accidentally added open statement

don't run tests if the `PB_SKIPTESTS` variable is set to true

…to `myget`

skip publishing packages unless the variable `PB_PUBLISHTYPE` is set to `myget`

…1102-070043 Merge dev15.6 to master

It's instead being added as a separate step in our official build.

enable publishing NuGet packages to an Azure Blob feed

remove MyGet package publishing

use a stable up-to-date version of MSBuild

dsyme · 2017-11-03T16:02:37Z

Failing on travis:

/home/travis/.local/share/dotnetcore/dotnet restore tools.fsproj
Failed to load error: libunwind.so.8: cannot open shared object file: No such file or directory
Failed to bind to CoreCLR at '/home/travis/.local/share/dotnetcore/shared/Microsoft.NETCore.App/2.0.0/libcoreclr.so'

System.Exception: dotnet restore tools.fsproj failed
  at Microsoft.FSharp.Core.PrintfModule+PrintFormatToStringThenFail@1379[TResult].Invoke (System.String message) [0x00001] in <5893d081904cf4daa745038381d09358>:0 
  at Microsoft.FSharp.Core.PrintfImpl+StringPrintfEnv`1[TResult].Finalize () [0x00012] in ```

dsyme · 2017-11-03T16:09:37Z

@forki It looks like the wrong dotnet is being run by this?

let dotnetExePath = DotNetCli.InstallDotNetSDK "2.0.2"
....
runDotnet __SOURCE_DIRECTORY__ "restore tools.fsproj"

I don't yet understand why, unless it is a bug in FAKE's DotNetCli.InstallDotNetSDK

dsyme · 2017-11-03T17:31:21Z

@forki @matthid If you could have a look at the failure on Travis related to the install of .NET SDK and restore of fcs\tools.proj I'd be really grateful

enricosada · 2017-11-06T22:46:42Z

@dsyme sent dsyme#1 i'll fix it there. status
it's building but is green

if you can enable push to PR for maintaners, i can fix these kind of errors (forki too) directly to PR

forki · 2017-11-07T05:46:23Z

That is the weird failure that I had in that other pr. I have no idea. 2.0.2 is working fine for safe stack build on Travis Am 03.11.2017 18:31 schrieb "Don Syme" <notifications@github.com>:

…

@forki <https://github.com/forki> @matthid <https://github.com/matthid> If you could have a look at the failure on Travis related to the install of .NET SDK and restore of fcs\tools.proj I'd be really grateful — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#833 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNOkbBsiGaOU6xtmhfqAl--QFMYpgks5sy03pgaJpZM4QRQUT> .

enricosada · 2017-11-07T09:24:56Z

@forki issue was .net core runtime dependencies, arent always installed by default
I added dotnet: 2.0.0 to travis so install the it (and so deps too)

install .net core sdk 2.0.2 in travis

dsyme · 2017-11-07T16:35:14Z

@enricosada Thank you so much!

brettfo and others added 30 commits August 16, 2017 12:31

Merge pull request #3446 from brettfo/merge-master-into-vs2017-rtm

f41a9a8

Merge master into vs2017-rtm

prevent endless async loop on Receive

64eb7dc

fix 3033 - make projects known to roslyn

03fb5b8

remove AddProject, now done via project tracker metadata ref conversion

f4120b3

merge

c107a16

Merge branch 'master' of http://github.com/Microsoft/visualfsharp int…

abbe394

…o proj1

remove flag for all but .NET 4.0 (#3482)

af471a3

Merge branch 'master' into proj1

094f373

merge

8381e23

Merge issues

8724793

merge

4710a17

Merge pull request #3594 from KevinRansom/mergetovs2017-rtm

eeac3a5

Merge master to vs2017-rtm

Merge branch 'proj1' of https://github.com/dsyme/visualfsharp into ds…

0e0b4f9

…yme-proj1

Merge pull request #3597 from KevinRansom/dsyme-proj1

6b68865

merge #3499 into vs2017-rtm

Merge pull request #3606 from KevinRansom/mergeintortm

8615245

Merge latest master into rtm

Merge branch 'master' of https://github.com/microsoft/visualfsharp in…

2b13f5d

…to vs2017-rtm

Merge pull request #3616 from KevinRansom/vs2017-rtm

d26de72

merge master into vs2017-rtm

update DEVGUIDE to add addiitional steps before running build (#3725)

db2e4e2

Split templates out into a seperate vsix (#3720)

6ecacd7

Merge branch 'vs2017-rtm' into master

57b2cfe

fix merge that picked up the wrong refactoring (#3732)

b714ecb

move GenerateSource attributes to be elements

a83598d

This fixes build issues when older versions of MSBuild are used.

publish templates VSIX (#3741)

2ccf874

Don't suggest variables explicitly marked unused (#3706)

481427f

* Add new test; fix run.pl regex and affected tests * Don't suggest variables explicitly marked unused

Parameterise rc location (#3744)

68f4187

undo #3536 (#3746)

503d167

* undo dotnet/fsharp#3536 * undo dotnet/fsharp#3536

undo #3536 (#3746) (#3749)

9fc3952

* undo dotnet/fsharp#3536 * undo dotnet/fsharp#3536

Do not commit autocompletion on bracket or pipe chars (#3718)

8adfa2f

* Do not commit autocompletion on bracket or pipe chars * Remove accidentally added open statement

brettfo and others added 13 commits November 1, 2017 12:48

Merge pull request #3847 from brettfo/skip-test-option

88379e7

don't run tests if the `PB_SKIPTESTS` variable is set to true

skip publishing packages unless the variable PB_PUBLISHTYPE is set …

9cd9f22

…to `myget`

Merge pull request #3857 from brettfo/package-publish

876e4a4

skip publishing packages unless the variable `PB_PUBLISHTYPE` is set to `myget`

Remove build fcs from branch dev15.5

0a9c0c1

Merge pull request #3860 from Microsoft/merges/dev15.6-to-master-2017…

26b66fb

…1102-070043 Merge dev15.6 to master

remove MyGet package publishing

41111ac

It's instead being added as a separate step in our official build.

use a stable up-to-date version of MSBuild

6b4a0bd

enable publishing NuGet packages to an Azure Blob feed

9fadedb

Merge pull request #3874 from brettfo/blob-publish

7542396

enable publishing NuGet packages to an Azure Blob feed

Merge pull request #3867 from brettfo/package-publish

f8b648b

remove MyGet package publishing

Merge pull request #3875 from brettfo/stable-msbuild

d903cf6

use a stable up-to-date version of MSBuild

integrate visualfsharp master and bump version

0d53d9c

fix build

44d037c

fix build

d8b4aea

try update fake

47e2135

dsyme mentioned this pull request Nov 3, 2017

Fix de-duplication of module names in ParseAndCheckFileInProject (FCS bug #819) #820

Closed

install .net core sdk 2.0.2 in travis

8411623

enricosada mentioned this pull request Nov 6, 2017

install .net core sdk 2.0.2 in travis dsyme/FSharp.Compiler.Service#1

Merged

enricosada added 3 commits November 6, 2017 23:49

empty commit

e75e32c

use 2.0.0, because 2.0.2 not yet in travis

297f286

use osx 10.12, because is the minimum for .net core sdk 2.0

d2f4646

Merge pull request #1 from enricosada/dsyme-i1

013ac24

install .net core sdk 2.0.2 in travis

dsyme merged commit ff80de4 into fsharp:master Nov 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

integrate visualfsharp master and bump version to 17.0.1 #833

integrate visualfsharp master and bump version to 17.0.1 #833

dsyme commented Nov 3, 2017

dsyme commented Nov 3, 2017 •

edited

Loading

dsyme commented Nov 3, 2017 •

edited

Loading

dsyme commented Nov 3, 2017

enricosada commented Nov 6, 2017 •

edited

Loading

forki commented Nov 7, 2017 via email

enricosada commented Nov 7, 2017 •

edited

Loading

dsyme commented Nov 7, 2017

integrate visualfsharp master and bump version to 17.0.1 #833

integrate visualfsharp master and bump version to 17.0.1 #833

Conversation

dsyme commented Nov 3, 2017

dsyme commented Nov 3, 2017 • edited Loading

dsyme commented Nov 3, 2017 • edited Loading

dsyme commented Nov 3, 2017

enricosada commented Nov 6, 2017 • edited Loading

forki commented Nov 7, 2017 via email

enricosada commented Nov 7, 2017 • edited Loading

dsyme commented Nov 7, 2017

dsyme commented Nov 3, 2017 •

edited

Loading

dsyme commented Nov 3, 2017 •

edited

Loading

enricosada commented Nov 6, 2017 •

edited

Loading

enricosada commented Nov 7, 2017 •

edited

Loading