Skip to content

Commit

Permalink
Remove href="javascript:;" in "save topics (Done)" button (go-gitea…
Browse files Browse the repository at this point in the history
…#21813)

To use an anchor tag as a button and have it be accessible I added
`role="button" tabindex="0"`,
[reference](https://stackoverflow.com/a/10510353/7414734).

* Closes go-gitea#19912
  • Loading branch information
yardenshoham authored and fsologureng committed Nov 22, 2022
1 parent 3e3150a commit 9e255cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion templates/repo/home.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
</div>
</div>
<div class="two wide column">
<a class="ui button primary" href="javascript:;" id="save_topic"
<a class="ui button primary" role="button" tabindex="0" id="save_topic"
data-link="{{.RepoLink}}/topics">{{.locale.Tr "repo.topic.done"}}</a>
</div>
</div>
Expand Down

0 comments on commit 9e255cf

Please sign in to comment.