forked from go-gitea/gitea
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add package registry cleanup rules (go-gitea#21658)
Fixes go-gitea#20514 Fixes go-gitea#20766 Fixes go-gitea#20631 This PR adds Cleanup Rules for the package registry. This allows to delete unneeded packages automatically. Cleanup rules can be set up from the user or org settings. Please have a look at the documentation because I'm not a native english speaker. Rule Form ![grafik](https://user-images.githubusercontent.com/1666336/199330792-c13918a6-e196-4e71-9f53-18554515edca.png) Rule List ![grafik](https://user-images.githubusercontent.com/1666336/199331261-5f6878e8-a80c-4985-800d-ebb3524b1a8d.png) Rule Preview ![grafik](https://user-images.githubusercontent.com/1666336/199330917-c95e4017-cf64-4142-a3e4-af18c4f127c3.png) Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
- Loading branch information
1 parent
7cf816d
commit f40ea41
Showing
27 changed files
with
1,243 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
--- | ||
date: "2022-11-01T00:00:00+00:00" | ||
title: "Storage" | ||
slug: "packages/storage" | ||
draft: false | ||
toc: false | ||
menu: | ||
sidebar: | ||
parent: "packages" | ||
name: "storage" | ||
weight: 5 | ||
identifier: "storage" | ||
--- | ||
|
||
# Storage | ||
|
||
This document describes the storage of the package registry and how it can be managed. | ||
|
||
**Table of Contents** | ||
|
||
{{< toc >}} | ||
|
||
## Deduplication | ||
|
||
The package registry has a build-in deduplication of uploaded blobs. | ||
If two identical files are uploaded only one blob is saved on the filesystem. | ||
This ensures no space is wasted for duplicated files. | ||
|
||
If two packages are uploaded with identical files, both packages will display the same size but on the filesystem they require only half of the size. | ||
Whenever a package gets deleted only the references to the underlaying blobs are removed. | ||
The blobs get not removed at this moment, so they still require space on the filesystem. | ||
When a new package gets uploaded the existing blobs may get referenced again. | ||
|
||
These unreferenced blobs get deleted by a [clean up job]({{< relref "doc/advanced/config-cheat-sheet.en-us.md#cron---cleanup-expired-packages-croncleanup_packages" >}}). | ||
The config setting `OLDER_THAN` configures how long unreferenced blobs are kept before they get deleted. | ||
|
||
## Cleanup Rules | ||
|
||
Package registries can become large over time without cleanup. | ||
It's recommended to delete unnecessary packages and set up cleanup rules to automatically manage the package registry usage. | ||
Every package owner (user or organization) manages the cleanup rules which are applied to their packages. | ||
|
||
|Setting|Description| | ||
|-|-| | ||
|Enabled|Turn the cleanup rule on or off.| | ||
|Type|Every rule manages a specific package type.| | ||
|Apply pattern to full package name|If enabled, the patterns below are applied to the full package name (`package/version`). Otherwise only the version (`version`) is used.| | ||
|Keep the most recent|How many versions to *always* keep for each package.| | ||
|Keep versions matching|The regex pattern that determines which versions to keep. An empty pattern keeps no version while `.+` keeps all versions. The container registry will always keep the `latest` version even if not configured.| | ||
|Remove versions older than|Remove only versions older than the selected days.| | ||
|Remove versions matching|The regex pattern that determines which versions to remove. An empty pattern or `.+` leads to the removal of every package if no other setting tells otherwise.| | ||
|
||
Every cleanup rule can show a preview of the affected packages. | ||
This can be used to check if the cleanup rules is proper configured. | ||
|
||
### Regex examples | ||
|
||
Regex patterns are automatically surrounded with `\A` and `\z` anchors. | ||
Do not include any `\A`, `\z`, `^` or `$` token in the regex patterns as they are not necessary. | ||
The patterns are case-insensitive which matches the behaviour of the package registry in Gitea. | ||
|
||
|Pattern|Description| | ||
|-|-| | ||
|`.*`|Match every possible version.| | ||
|`v.+`|Match versions that start with `v`.| | ||
|`release`|Match only the version `release`.| | ||
|`release.*`|Match versions that are either named or start with `release`.| | ||
|`.+-temp-.+`|Match versions that contain `-temp-`.| | ||
|`v.+\|release`|Match versions that either start with `v` or are named `release`.| | ||
|`package/v.+\|other/release`|Match versions of the package `package` that start with `v` or the version `release` of the package `other`. This needs the setting *Apply pattern to full package name* enabled.| | ||
|
||
### How the cleanup rules work | ||
|
||
The cleanup rules are part of the [clean up job]({{< relref "doc/advanced/config-cheat-sheet.en-us.md#cron---cleanup-expired-packages-croncleanup_packages" >}}) and run periodicly. | ||
|
||
The cleanup rule: | ||
|
||
1. Collects all packages of the package type for the owners registry. | ||
1. For every package it collects all versions. | ||
1. Excludes from the list the # versions based on the *Keep the most recent* value. | ||
1. Excludes from the list any versions matching the *Keep versions matching* value. | ||
1. Excludes from the list the versions more recent than the *Remove versions older than* value. | ||
1. Excludes from the list any versions not matching the *Remove versions matching* value. | ||
1. Deletes the remaining versions. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
// Copyright 2022 The Gitea Authors. All rights reserved. | ||
// Use of this source code is governed by a MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package v1_19 //nolint | ||
|
||
import ( | ||
"code.gitea.io/gitea/modules/timeutil" | ||
|
||
"xorm.io/xorm" | ||
) | ||
|
||
func CreatePackageCleanupRuleTable(x *xorm.Engine) error { | ||
type PackageCleanupRule struct { | ||
ID int64 `xorm:"pk autoincr"` | ||
Enabled bool `xorm:"INDEX NOT NULL DEFAULT false"` | ||
OwnerID int64 `xorm:"UNIQUE(s) INDEX NOT NULL DEFAULT 0"` | ||
Type string `xorm:"UNIQUE(s) INDEX NOT NULL"` | ||
KeepCount int `xorm:"NOT NULL DEFAULT 0"` | ||
KeepPattern string `xorm:"NOT NULL DEFAULT ''"` | ||
RemoveDays int `xorm:"NOT NULL DEFAULT 0"` | ||
RemovePattern string `xorm:"NOT NULL DEFAULT ''"` | ||
MatchFullName bool `xorm:"NOT NULL DEFAULT false"` | ||
CreatedUnix timeutil.TimeStamp `xorm:"created NOT NULL DEFAULT 0"` | ||
UpdatedUnix timeutil.TimeStamp `xorm:"updated NOT NULL DEFAULT 0"` | ||
} | ||
|
||
return x.Sync2(new(PackageCleanupRule)) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,110 @@ | ||
// Copyright 2022 The Gitea Authors. All rights reserved. | ||
// Use of this source code is governed by a MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package packages | ||
|
||
import ( | ||
"context" | ||
"errors" | ||
"fmt" | ||
"regexp" | ||
|
||
"code.gitea.io/gitea/models/db" | ||
"code.gitea.io/gitea/modules/timeutil" | ||
|
||
"xorm.io/builder" | ||
) | ||
|
||
var ErrPackageCleanupRuleNotExist = errors.New("Package blob does not exist") | ||
|
||
func init() { | ||
db.RegisterModel(new(PackageCleanupRule)) | ||
} | ||
|
||
// PackageCleanupRule represents a rule which describes when to clean up package versions | ||
type PackageCleanupRule struct { | ||
ID int64 `xorm:"pk autoincr"` | ||
Enabled bool `xorm:"INDEX NOT NULL DEFAULT false"` | ||
OwnerID int64 `xorm:"UNIQUE(s) INDEX NOT NULL DEFAULT 0"` | ||
Type Type `xorm:"UNIQUE(s) INDEX NOT NULL"` | ||
KeepCount int `xorm:"NOT NULL DEFAULT 0"` | ||
KeepPattern string `xorm:"NOT NULL DEFAULT ''"` | ||
KeepPatternMatcher *regexp.Regexp `xorm:"-"` | ||
RemoveDays int `xorm:"NOT NULL DEFAULT 0"` | ||
RemovePattern string `xorm:"NOT NULL DEFAULT ''"` | ||
RemovePatternMatcher *regexp.Regexp `xorm:"-"` | ||
MatchFullName bool `xorm:"NOT NULL DEFAULT false"` | ||
CreatedUnix timeutil.TimeStamp `xorm:"created NOT NULL DEFAULT 0"` | ||
UpdatedUnix timeutil.TimeStamp `xorm:"updated NOT NULL DEFAULT 0"` | ||
} | ||
|
||
func (pcr *PackageCleanupRule) CompiledPattern() error { | ||
if pcr.KeepPatternMatcher != nil || pcr.RemovePatternMatcher != nil { | ||
return nil | ||
} | ||
|
||
if pcr.KeepPattern != "" { | ||
var err error | ||
pcr.KeepPatternMatcher, err = regexp.Compile(fmt.Sprintf(`(?i)\A%s\z`, pcr.KeepPattern)) | ||
if err != nil { | ||
return err | ||
} | ||
} | ||
|
||
if pcr.RemovePattern != "" { | ||
var err error | ||
pcr.RemovePatternMatcher, err = regexp.Compile(fmt.Sprintf(`(?i)\A%s\z`, pcr.RemovePattern)) | ||
if err != nil { | ||
return err | ||
} | ||
} | ||
|
||
return nil | ||
} | ||
|
||
func InsertCleanupRule(ctx context.Context, pcr *PackageCleanupRule) (*PackageCleanupRule, error) { | ||
return pcr, db.Insert(ctx, pcr) | ||
} | ||
|
||
func GetCleanupRuleByID(ctx context.Context, id int64) (*PackageCleanupRule, error) { | ||
pcr := &PackageCleanupRule{} | ||
|
||
has, err := db.GetEngine(ctx).ID(id).Get(pcr) | ||
if err != nil { | ||
return nil, err | ||
} | ||
if !has { | ||
return nil, ErrPackageCleanupRuleNotExist | ||
} | ||
return pcr, nil | ||
} | ||
|
||
func UpdateCleanupRule(ctx context.Context, pcr *PackageCleanupRule) error { | ||
_, err := db.GetEngine(ctx).ID(pcr.ID).AllCols().Update(pcr) | ||
return err | ||
} | ||
|
||
func GetCleanupRulesByOwner(ctx context.Context, ownerID int64) ([]*PackageCleanupRule, error) { | ||
pcrs := make([]*PackageCleanupRule, 0, 10) | ||
return pcrs, db.GetEngine(ctx).Where("owner_id = ?", ownerID).Find(&pcrs) | ||
} | ||
|
||
func DeleteCleanupRuleByID(ctx context.Context, ruleID int64) error { | ||
_, err := db.GetEngine(ctx).ID(ruleID).Delete(&PackageCleanupRule{}) | ||
return err | ||
} | ||
|
||
func HasOwnerCleanupRuleForPackageType(ctx context.Context, ownerID int64, packageType Type) (bool, error) { | ||
return db.GetEngine(ctx). | ||
Where("owner_id = ? AND type = ?", ownerID, packageType). | ||
Exist(&PackageCleanupRule{}) | ||
} | ||
|
||
func IterateEnabledCleanupRules(ctx context.Context, callback func(context.Context, *PackageCleanupRule) error) error { | ||
return db.Iterate( | ||
ctx, | ||
builder.Eq{"enabled": true}, | ||
callback, | ||
) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
// Copyright 2022 The Gitea Authors. All rights reserved. | ||
// Use of this source code is governed by a MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package org | ||
|
||
import ( | ||
"fmt" | ||
"net/http" | ||
|
||
"code.gitea.io/gitea/modules/base" | ||
"code.gitea.io/gitea/modules/context" | ||
"code.gitea.io/gitea/modules/setting" | ||
shared "code.gitea.io/gitea/routers/web/shared/packages" | ||
) | ||
|
||
const ( | ||
tplSettingsPackages base.TplName = "org/settings/packages" | ||
tplSettingsPackagesRuleEdit base.TplName = "org/settings/packages_cleanup_rules_edit" | ||
tplSettingsPackagesRulePreview base.TplName = "org/settings/packages_cleanup_rules_preview" | ||
) | ||
|
||
func Packages(ctx *context.Context) { | ||
ctx.Data["Title"] = ctx.Tr("packages.title") | ||
ctx.Data["PageIsOrgSettings"] = true | ||
ctx.Data["PageIsSettingsPackages"] = true | ||
|
||
shared.SetPackagesContext(ctx, ctx.ContextUser) | ||
|
||
ctx.HTML(http.StatusOK, tplSettingsPackages) | ||
} | ||
|
||
func PackagesRuleAdd(ctx *context.Context) { | ||
ctx.Data["Title"] = ctx.Tr("packages.title") | ||
ctx.Data["PageIsOrgSettings"] = true | ||
ctx.Data["PageIsSettingsPackages"] = true | ||
|
||
shared.SetRuleAddContext(ctx) | ||
|
||
ctx.HTML(http.StatusOK, tplSettingsPackagesRuleEdit) | ||
} | ||
|
||
func PackagesRuleEdit(ctx *context.Context) { | ||
ctx.Data["Title"] = ctx.Tr("packages.title") | ||
ctx.Data["PageIsOrgSettings"] = true | ||
ctx.Data["PageIsSettingsPackages"] = true | ||
|
||
shared.SetRuleEditContext(ctx, ctx.ContextUser) | ||
|
||
ctx.HTML(http.StatusOK, tplSettingsPackagesRuleEdit) | ||
} | ||
|
||
func PackagesRuleAddPost(ctx *context.Context) { | ||
ctx.Data["Title"] = ctx.Tr("packages.title") | ||
ctx.Data["PageIsOrgSettings"] = true | ||
ctx.Data["PageIsSettingsPackages"] = true | ||
|
||
shared.PerformRuleAddPost( | ||
ctx, | ||
ctx.ContextUser, | ||
fmt.Sprintf("%s/org/%s/settings/packages", setting.AppSubURL, ctx.ContextUser.Name), | ||
tplSettingsPackagesRuleEdit, | ||
) | ||
} | ||
|
||
func PackagesRuleEditPost(ctx *context.Context) { | ||
ctx.Data["Title"] = ctx.Tr("packages.title") | ||
ctx.Data["PageIsOrgSettings"] = true | ||
ctx.Data["PageIsSettingsPackages"] = true | ||
|
||
shared.PerformRuleEditPost( | ||
ctx, | ||
ctx.ContextUser, | ||
fmt.Sprintf("%s/org/%s/settings/packages", setting.AppSubURL, ctx.ContextUser.Name), | ||
tplSettingsPackagesRuleEdit, | ||
) | ||
} | ||
|
||
func PackagesRulePreview(ctx *context.Context) { | ||
ctx.Data["Title"] = ctx.Tr("packages.title") | ||
ctx.Data["PageIsOrgSettings"] = true | ||
ctx.Data["PageIsSettingsPackages"] = true | ||
|
||
shared.SetRulePreviewContext(ctx, ctx.ContextUser) | ||
|
||
ctx.HTML(http.StatusOK, tplSettingsPackagesRulePreview) | ||
} |
Oops, something went wrong.