feat(xml): add support for list objects #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsouza
reviewed
May 2, 2023
fsouza
force-pushed
the
feature/xml-list-objects
branch
from
a36199c to
9a77d53
Compare
fsouza
reviewed
May 3, 2023
There was a problem hiding this comment.
I pushed some changes to your branch to get the PR green, but feel free to override them.
I think this looks good overall, but I'd like to have the pagination change as a separate PR or available only through the HTTP API, we don't need to expose pagination as part of the library surface (like let's implement it in an unexported method that gets used by ListObjectsWithOptions).
goober
force-pushed
the
feature/xml-list-objects
branch
from
71dc486 to
7e56881
Compare
|
Thanks for the review @fsouza, and I agree that we should strive for not breaking the current api. So I have removed everything that is related to pagination in the current PR. And then we could have another look at that in a separate PR later on, if necessary. |
goober
force-pushed
the
feature/xml-list-objects
branch
from
7e56881 to
be4a0d6
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to add support for listing objects according to the Google Cloud Storage XML API