Disallow composing more than 32 objects at once #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsouza
reviewed
Jul 29, 2023
The Google Cloud Storage API does not allow it either (see
[documentation][1]). Trying to compose more than 32 objects at once
qualifies as a 400 BadRequest. This is the body that GCS returns in such
a case:
```json
{
"error": {
"code": 400,
"message": "The number of source components provided (33) exceeds the maximum (32)",
"errors": [
{
"message": "The number of source components provided (33) exceeds the maximum (32)",
"domain": "global",
"reason": "invalid"
}
]
}
}
```
Note that GCS supports composing more than 32 objects into one. But it
requires multiple `compose` calls, each one composing at most 32 objects
in one go.
[1]: https://cloud.google.com/storage/docs/json_api/v1/objects/compose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Google Cloud Storage API does not allow it either (see documentation). Trying to compose more than 32 objects at once qualifies as a 400 BadRequest. This is the body that GCS returns in such a case:
{ "error": { "code": 400, "message": "The number of source components provided (33) exceeds the maximum (32)", "errors": [ { "message": "The number of source components provided (33) exceeds the maximum (32)", "domain": "global", "reason": "invalid" } ] } }Note that GCS supports composing more than 32 objects into one. But it requires multiple
composecalls, each one composing at most 32 objects in one go.