Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional bucket response attributes #1258

Merged
merged 3 commits into from
Jul 30, 2023
Merged

Additional bucket response attributes #1258

merged 3 commits into from
Jul 30, 2023

Commits on Jul 29, 2023

  1. Support bucket creation time in the FS backend

    This was already supported in the Memory backend.
    
    As bucket creation time we use the creation time attribute of the
    filesystem directory node backing it.
    manuteleco committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    de0a037 View commit details
    Browse the repository at this point in the history
  2. Include the updated attribute in Bucket object responses

    Some client libraries, like [googleCloudStorageR][1], expect the
    `updated` attribute of the [Bucket][2] object to be returned.
    
    Its value isn't hugely important, so we just use the same value as for
    `timeCreated`, also considering that update timestamps are not being
    tracked yet.
    
    [1]: https://cran.r-project.org/web/packages/googleCloudStorageR
    [2]: https://cloud.google.com/storage/docs/json_api/v1/buckets
    manuteleco committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    d1d1e94 View commit details
    Browse the repository at this point in the history
  3. Include the storageClass attribute in Bucket object responses

    Some client libraries, like [googleCloudStorageR][1], expect the
    `storageClass` attribute of the [Bucket][2] object to be returned.
    
    Its value isn't hugely important, so we just use "STANDARD".
    
    [1]: https://cran.r-project.org/web/packages/googleCloudStorageR
    [2]: https://cloud.google.com/storage/docs/json_api/v1/buckets
    manuteleco committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    f368461 View commit details
    Browse the repository at this point in the history