Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore 4443 as default port for '-scheme http' as before PR #1215 #1272

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Restore 4443 as default port for '-scheme http' as before PR #1215 #1272

merged 1 commit into from
Aug 1, 2023

Conversation

raz-amir
Copy link
Contributor

@raz-amir raz-amir commented Aug 1, 2023

Fix breaking change caused by PR #1215:
Restore the default port that was used for -scheme http before the integration that PR

@raz-amir
Copy link
Contributor Author

raz-amir commented Aug 1, 2023

@fsouza, here is the fix. Thanks!

@raz-amir raz-amir marked this pull request as ready for review August 1, 2023 07:25
@raz-amir raz-amir mentioned this pull request Aug 1, 2023
Closed
@fsouza fsouza merged commit d717a60 into fsouza:main Aug 1, 2023
31 checks passed
@fsouza
Copy link
Owner

fsouza commented Aug 1, 2023

Thanks for the quick fix, I push 1.47.1 shortly.

@fsouza fsouza mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsouza fsouza fsouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raz-amir @fsouza