Additional object response attributes #1524
Conversation
Some GCS client libraries (like [this one][1]), are quite strict when it comes to the set of attributes they expect to find in the response. If any of those attributes is missing, they fail to deserialize the response. Here we introduce three new attributes in the Object response: * `SelfLink` * `MediaLink` * `Metageneration` `SelfLink` cannot be tested using the Go GCS client library, as it is not included in the [`ObjectAttrs`][2] struct. For the `Metageneration` we just hardcode the value `"1"`, considering that we are not keeping track of it internally and `"1"` happens to be the correct value most of the times anyway. [1]: https://crates.io/crates/google-cloud-storage [2]: https://pkg.go.dev/cloud.google.com/go/storage@v1.39.0#ObjectAttrs
|
Note that this PR will conflict with #1520 around the definition and use of In case that's helpful, here are the changes from all of my PRs from today combined into a single sequence of commits: manuteleco/fake-gcs-server@abe467c...0887d58. |
fakestorage/object_test.go
Outdated
| @@ -186,6 +186,14 @@ func checkObjectAttrs(testObj Object, attrs *storage.ObjectAttrs, t *testing.T) | |||
| t.Errorf("wrong MetaHeader returned\nwant %s\ngot %v", testObj.Metadata["MetaHeader"], val) | |||
| } | |||
| } | |||
| externalUrl := "" // We don't set any `externalURL` value during tests. | |||
There was a problem hiding this comment.
super nit, but can you call this (and others) externalURL?
(I thought there was a vet rule for this in Go, but I guess I'm wrong)
There was a problem hiding this comment.
Sure thing. Thanks for pointing it out; I wasn't aware.
There was a problem hiding this comment.
Addressed in 97841f3.
externalUrl -> externalURL
fakestorage/response.go
Outdated
| SelfLink: externalUrl + "/storage/v1/b/" + obj.BucketName + "/o/" + obj.Name, | ||
| MediaLink: externalUrl + "/download/storage/v1/b/" + obj.BucketName + "/o/" + obj.Name + "?alt=media", |
There was a problem hiding this comment.
I should probably URL-encode these. I'll take care of that as well.
There was a problem hiding this comment.
Addressed in 6c65141.
Escape URL path components
|
@fsouza Is it possible to push a new docker image so we can use this change?, the last one is 2 months old and there are also other new changes which has gotten pushed. |
Yes, I'll publish a new release later today! |
Many thanks! |
Some GCS client libraries (like this one), are quite strict when it comes to the set of attributes they expect to find in the response. If any of those attributes is missing, they fail to deserialize the response.
Here we introduce three new attributes in the Object response:
SelfLinkMediaLinkMetagenerationSelfLinkcannot be tested using the Go GCS client library, as it is not included in theObjectAttrsstruct.For the
Metagenerationwe just hardcode the value"1", considering that we are not keeping track of it internally and"1"happens to be the correct value most of the times anyway.Edited: I believe this PR fixes #758, which I only noticed after the fact.