-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file download to node example #530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeaton-overleaf
commented
Jul 12, 2021
fsouza
reviewed
Jul 12, 2021
fsouza
reviewed
Jul 13, 2021
fsouza
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! I'll push a release once this is merged.
I'll fix the dotnet issue on master. |
Temporary workaround for #532 so we can get this PR in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-compose.yaml
to start thefake-gcs
service (copied from thedotnet
example, with the addition of abuild
path and avolumes
mount to load the example data).The
download
example is currently failing when used with@google-cloud/storage
> v5.8.1 unlessvalidation: false
is set, which isn't ideal - it seems thatfake-gcs
needs to be setting ax-goog-hash
header on the response.I've added a line of code that sets
X-Goog-Hash
on the download response, but I'm not sure when either ofobj.Crc32c
orobj.Md5Hash
are guaranteed to be set on the object, so someone with more knowledge of the server will need to finish this off.Closes #529.