Skip to content
This repository has been archived by the owner on Oct 31, 2021. It is now read-only.

navigate to source for Octokit.net not working #947

Closed
ctaggart opened this issue Mar 9, 2015 · 3 comments
Closed

navigate to source for Octokit.net not working #947

ctaggart opened this issue Mar 9, 2015 · 3 comments

Comments

@ctaggart
Copy link
Contributor

ctaggart commented Mar 9, 2015

I'm testing out the latest build which has the Navigate to Source feature.
https://ci.appveyor.com/project/dungpa/visualfsharppowertools/build/1.8.0-a1503071249/artifacts

I created a new project with this NuGet packages.config:

<?xml version="1.0" encoding="utf-8"?>
<packages>
  <package id="Octokit" version="0.7.2" targetFramework="net45" />
  <package id="SourceLink.Core" version="0.5.0-ci1411242108" targetFramework="net45" />
</packages>

The Library1.fs:

module Test

let md5 = SourceLink.Crypto.hashMD5 "a.txt"

// https://github.com/octokit/octokit.net/
let dt = Octokit.Helpers.UnixTimestampExtensions.FromUnixTime 1425868070L
let github = Octokit.GitHubClient(Octokit.ProductHeaderValue "MyAmazingApp")
let a = github.Activity.Events.GetAll()
()

It correctly navigates to hashMD5 implementation which is awesome to see!

It does not work when I try to navigate to FromUnixTime or GitHubClient constructor or GetAll. It doesn't seem to be working for the Octokit.net library. It is source indexed.

@dungpa
Copy link
Contributor

dungpa commented Mar 9, 2015

Is there any error message being shown on the status bar? Or does VS just silently do nothing?

@ctaggart
Copy link
Contributor Author

ctaggart commented Mar 9, 2015

If the metadata option is enabled, it goes to the metadata. If the metadata option is disabled, the status bar shows:
image
I am able to start debugging and step into FromUnixTime so I know it is source indexed correctly.

@dungpa
Copy link
Contributor

dungpa commented Nov 5, 2015

This issue is not worth fixing unless SourceLink has better support for symbols at design time.

@dungpa dungpa closed this as completed Nov 5, 2015
@dungpa dungpa added the deferred label Nov 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants