Skip to content
This repository has been archived by the owner on Oct 31, 2021. It is now read-only.

Use reflection to get source location when FCS doesn't give enough information #948

Closed
wants to merge 1 commit into from

Conversation

dungpa
Copy link
Contributor

@dungpa dungpa commented Mar 9, 2015

Partial fix for #947 (NOT YET READY).

For Octokit NuGet package, FCS returns faulty ranges (no range or a dummy range with wrong information). We try to use Reflection to recover source locations. I'm not sure it's a good approach; any other idea is appreciated.

@ctaggart It seems pdbReader.GetMethod doesn't work correctly for any overriden/abstract member e.g. any symbol from this line:

let a = github.Activity.Events.GetAll()

Is this a SourceLink's bug? Any idea?

@dungpa
Copy link
Contributor Author

dungpa commented Mar 12, 2015

@ctaggart I need your help with this one to move forward. Should I wait for changes in SourceLink or discard this PR as we don't support source-indexed C# assemblies at this point?

@ctaggart
Copy link
Contributor

ctaggart commented Apr 6, 2015

As I just mentioned in ctaggart/SourceLink#63, not all files or methods gets indexed by the compilers. F12 at design time will only work with concrete methods that get source indexed, not any of the interfaces.

@dungpa
Copy link
Contributor Author

dungpa commented Apr 7, 2015

That sounds really limiting. On a related note, can signature files (*.fsi) be source indexed?

@dungpa
Copy link
Contributor Author

dungpa commented Jun 10, 2015

Closing this PR until there is more versatile support for pdb files from SourceLink.

@dungpa dungpa closed this Jun 10, 2015
@dungpa dungpa deleted the octokit-bug branch June 10, 2015 10:12
@ctaggart
Copy link
Contributor

I believe Portable PDBs ctaggart/SourceLink#93 will solve several of the issues. I'll create a new issue in this repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants