Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

pdbReader.GetMethod doesn't work correctly for any overriden/abstract member #63

Closed
ctaggart opened this issue Mar 10, 2015 · 4 comments
Assignees

Comments

@ctaggart
Copy link
Owner

According to @dungpa. fsprojects-archive/zzarchive-VisualFSharpPowerTools#948
I'll have to take a look.

@ctaggart ctaggart self-assigned this Mar 10, 2015
@ctaggart ctaggart added the bug label Mar 10, 2015
@dungpa
Copy link

dungpa commented Mar 10, 2015

pdbReader.GetMethod returns None for those members. Perhaps there is some trickery in passing a right metadata token? I think it should be easy to replicate using https://github.com/ctaggart/SourceLink/blob/master/ConsoleTest/Program.fs.

@ctaggart ctaggart modified the milestones: 0.5.0, 0.5.1 Mar 15, 2015
@ctaggart
Copy link
Owner Author

@dungpa I'm busy trying to finish up SourceLink.exe so that I can release 0.5.0. I've marked this for the first bug fix release 0.5.1.

@dungpa
Copy link

dungpa commented Mar 22, 2015

Fair enough. I would like to release VFPT 1.8.0 in the end of this month. Would be great if we can fix this beforehand.

@ctaggart
Copy link
Owner Author

ctaggart commented Apr 6, 2015

Sorry for the delay. I finally found time to look at this today. The compilers choose which methods to add to the pdb. At runtime, it is going to the the concrete type and not the interface. Unfortunately, interfaces are not source indexed and you will not be able to F12 into them at design time.

image

So it is not a bug. It is a limitation for design time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants