Skip to content
This repository has been archived by the owner on Oct 31, 2021. It is now read-only.

Clearing FCS caches optimization #1076

Merged

Conversation

vasily-kirichenko
Copy link
Contributor

WIP

@dungpa
Copy link
Contributor

dungpa commented Aug 9, 2015

Looking at old conversations (e.g. #474), ClearLanguageServiceRootCachesAndCollectAndFinalizeAllTransients was added when we chased memory leaks.

Now we know that it's mostly because of type providers and VFT itself, do you think there is any problem with merging this?

@vasily-kirichenko
Copy link
Contributor Author

As it's fixed #1037, I think we should merge this. I'll use this version at work and will see whether it's introduced any leaks.

@vasily-kirichenko vasily-kirichenko force-pushed the optimize-caches-clearing branch from af8df8b to 08e8fad Compare August 9, 2015 10:07
@dungpa
Copy link
Contributor

dungpa commented Aug 9, 2015

:shipit:

dungpa added a commit that referenced this pull request Aug 9, 2015
@dungpa dungpa merged commit 4633035 into fsprojects-archive:master Aug 9, 2015
@vasily-kirichenko vasily-kirichenko deleted the optimize-caches-clearing branch November 1, 2015 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants