-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate classic .NET projects to new project structure #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Then you can get rid of the other project file by switching to <TargetFrameworks>netstandard2.0;net40</TargetFrameworks>
. The only issue is VS 2017 debugging. C# picks the first framework listed to debug against by default. F# doesn't work too well in 15.5. dotnet/fsharp#4084
Ah, the Travis CI builds are failing:
I'll find the link to tell dotnet to use mono to build net461. |
So it sounds like you can just call |
Actually, it looks like it's testing that fails. Think it might be an xunit issue? |
Yeah, you are right. I wonder if there is a way to limit the tests to just netstandard on Travis. |
Yeah, until they fix that issue, you'd have to run the net461 tests another way on Unix. You can use the
You will have to combine the unit test project into one or specify them separately. |
I was hoping that was going to work. In one of my projects, I still have to call the console runner on Unix.
|
This PR moves any outstanding legacy
*proj
files to the new project structure.