XamarinHelper - file name not quoted by calling zipalign

[WebDucer]

Description

The call of jarsigner quote the file names:

jarsigner -sigalg SHA1withRSA -digestalg SHA1 -keystore "C:\Users\er\Documents\Visual Studio 2015\Projects\BuildTest\BuildTestStore" -storepass 123456789 -signedjar "C:\Users\er\Documents\Visual Studio 2015\Projects\BuildTest\Output\BuildTest.Droid-Signed.apk" "C:\Users\er\Documents\Visual Studio 2015\Projects\BuildTest\Output\BuildTest.Droid.apk" BuildTest

The call of zipalign does not:

zipalign -f -v 4 C:\Users\er\Documents\Visual Studio 2015\Projects\BuildTest\Output\BuildTest.Droid-Signed.apk C:\Users\er\Documents\Visual Studio 2015\Projects\BuildTest\Output\BuildTest.Droid-SignedAndAligned.apk

https://github.com/fsharp/FAKE/blob/master/src/app/FakeLib/XamarinHelper.fs#L313

Repro steps

Description "Build Xamarin Android app"
Target "BuildAndroidApp" (fun _ ->
    AndroidPackage (fun p ->
        {p with
            Configuration = "Release"
            ProjectPath = androidProjectPath
            OutputPath = baseOutput
            PackageAbiTargets = AndroidPackageAbiParam.OneApkForAll
        }
    )
    |> AndroidSignAndAlign (fun a ->
        {a with
            KeystorePath =  "BuildTestStore"
            KeystorePassword = "123456789"
            KeystoreAlias = "BuildTest"
        })
    |> (fun p -> trace p.FullName)
)

Expected behavior

Filenames should be quoted also for zipalign.

Actual behavior

Filenames are not quoted.

Known workarounds

Paths without blancs.

Related information

• Win 10
• Visual Studio 2015 with Xamarin

[WebDucer]

I'll fix this.