-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The continuing intermittent macOS CI build failures #2814
Comments
Ok it seems the test is asserting that there is no output. But Fake.Core.Trace.TraceFAKE will be output. Now the question is, if proc.StartTime fails to get, is it just that this platform didn't work and we can ignore, or is it so important error that we should fail the test? |
Debugging of #2814 Adds catching `PlatformNotSupportedException` and `NotSupportedException` on a process starting
The way it catches the exceptions and returns DateTime.Now suggests an explicit decision to not treat it as an error, but I don't know any history behind the decision |
We seem to still have an intermittent CI build failure on macOS, with errors about not being able to get the start time of a process -
https://github.com/fsprojects/FAKE/actions/runs/10654117014/job/29530030223#step:8:9395
Looking at the code, it seems to expect to fail to get the process start time sometimes, and responds by logging it and returning DateTime.Now -
FAKE/src/app/Fake.Core.Process/Process.fs
Line 470 in fac7295
There are sometimes multiple instances of that error in the logs but the only one that seems to make it break is in the
no dependencies hello world and casing #2314
test case atFAKE/src/test/Fake.Core.IntegrationTests/SimpleHelloWorldTests.fs
Line 79 in fac7295
FAKE/src/test/Fake.Core.IntegrationTests/SimpleHelloWorldTests.fs
Line 95 in fac7295
I'm not sure why the error occurs (maybe it is just because the test process exits too quickly and is gone by the time the runner tries to get the time), so I 'm not sure if there is a bug or if the test is a bit too strict?
The error only seems to happen on macOS, though there is a different code path for Windows vs. macOS/Linux that might effect things there.
The text was updated successfully, but these errors were encountered: