NuGet helper does not finds the tool if present in PATH

[bbenoist]

Hello there,

I am encountering a behavior that I did not expected while using NuGet for creating packages.

The RestorePackageHelper::findNuget function does not search for the presence of the executable in the PATH environment variable.

Is it voluntary or can I propose a PR for this?

[forki]

yes this sounds like a good addition.

[forki]

btw: there is a tryFindFileOnPath in ProcessHelper.fs - it should help you to implement this.

[bbenoist]

I saw that you worked on it while I was preparing my PR 😥.
Here is my work on the FAKE source code since yesterday in case you still want to integrate some parts of it:

Directly related to this issue

• feature/isvalidpath feature/split-environvar
  • ==> feature/path-directories
  • ==> feature/nuget-in-path

Indirectly related to this issue

• bugfix/typo
• bugfix/system-directory
• feature/code-style
  • ==> feature/trim-trailing-whitespace

[forki]

please send a pull request. I fixed another bug. I think the Nuget path finder is still broken.

[bbenoist]

OK, I will continue on it.

However, after remarking that the master branch has been reset to a previous commit, then, diverged from its original state, one question remains:

Should I rebase and recreate all my branches or will you merge them into master anyway?

As I have previously been confronted with such problems and eliminated most of them with an adapted workflow, here is some useful information about the available stategies:

• Git team workflows: merge or rebase
• Comparing Workflows
• Merging vs Rebasing.
• Reset, Checkout, and Revert

[forki]

I had to remove a bad commit. I agree it would have been better to just revert that thingy.
Plese rebase your commit on current master.