Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sonar options #1172

Merged
merged 2 commits into from
Mar 13, 2016
Merged

New sonar options #1172

merged 2 commits into from
Mar 13, 2016

Conversation

Slesa
Copy link
Contributor

@Slesa Slesa commented Mar 9, 2016

Added missing parameters /d and /s to the SonarQube parameters.

@Slesa Slesa mentioned this pull request Mar 9, 2016
@philipooo
Copy link
Contributor

This already looks very good!

But am I right saying it's currently not possible to pass the corresponding values for the parameters?
e.g. Settings = [("sonar.debug",True);("sonar.login","qwe34234iqeri")]

There is one use-case that is not yet covered by this solution: We (company) are not storing the credentials in our SonarQube.Analytics.xml, instead we are passing them directly to the command line by our buildserver. Since the analyser does not store the credentials in the filesystem the execution of end fails because of the lack of the credentials. We have to pass sonar.login (and optionally sonar.password, if someone is not using tokens) again to the call of end.

A solution could be to add an additional value to the tuples in the settings-property like:
Settings = [("sonar.debug",True,Begin);("sonar.login","qwe34234iqeri",BeginEnd)]

Cheers

@Slesa
Copy link
Contributor Author

Slesa commented Mar 11, 2016

Probably the settings currently have to be Settings = [("sonar.debug=True");("sonar.login=qwe34234iqeri")]. Should I add a second field EndSettings? Tuples in settings is a bit uncomfortable, isn't it?

forki added a commit that referenced this pull request Mar 13, 2016
@forki forki merged commit ca959b4 into fsprojects:master Mar 13, 2016
@forki
Copy link
Member

forki commented Mar 13, 2016

thanks

@Slesa Slesa deleted the NewSonarOptions branch March 23, 2016 10:37
@philipooo
Copy link
Contributor

Ok, of course its possible to add the value directly to the list, but the sample does not show this.
https://github.com/fsharp/FAKE/pull/1172/files#diff-83519ec9f82c298670e2d0087edf4c98R59

A second field EndSettings would be totaly fine for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants