Add contents of AssemblyInformationalVersionAttribute to the AssemblyVersionInformation class
#1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
AssemblyInformationalVersionattribute often contains information not available in theAssemblyVersionattribute, such as beta or rc information, certain features (like logging) of other software could benefit from having the more descriptive version information.Decided to work this up because we recently moved to using
FAKEto build some older internal projects at work, which means ourAssemblyInfofiles are now auto-generated based on the release notes file. Beta 4 for version1.2.3used to be manually-entered as1.2.3.4; now the version is entered as1.2.3-beta4, and the auto-generatedAssemblyInfofile writes this as1.2.3. Since bugs can come and go quickly during betas, having the rest of the version text would greatly improve the usefulness of logging.