Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't merge] demonstrate #1187 #1207

Closed
wants to merge 2 commits into from
Closed

[Don't merge] demonstrate #1187 #1207

wants to merge 2 commits into from

Conversation

0x53A
Copy link
Contributor

@0x53A 0x53A commented Apr 7, 2016

This demonstrates #1187:

If $ErrorActionPreference = "Stop" was set, powershell converts any sub-process writing to STDERR into an exception.

When the output of FAKE is redirected (either file-redirection, or just running it in ISE), it writes an empty string to STDERR after it successfully finishes.
The exit code of FAKE is 0.

My guess is that it flushes some kind of buffer before exiting.

I did a manual binary search with the package versions, and it looks like 4.14.5 is the last GOOD version, 4.14.7 is the first BAD version.

I will try to find the exact commit next week...

@forki
Copy link
Member

forki commented Apr 9, 2016

What about this now?

@0x53A
Copy link
Contributor Author

0x53A commented Apr 9, 2016

This script runner was just quickly thrown together.
I will try to create a unit test which checks that a successful build script does not write to stderr.

@0x53A 0x53A closed this Apr 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants