Use UTF-8 encoding for process output on Mono #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes encoding issues when encoding property is not set: Refs fsprojects#1212. This is a revised version of commit 2d63a45, which broke external processes when standard error/output is not redirected: Refs fsprojects#1213 This commit only sets the encoding when output is redirected.
|
ok. let's try that one |
forki
added a commit
that referenced
this pull request
Jun 29, 2017
forki
added a commit
that referenced
this pull request
Jun 29, 2017
forki
added a commit
that referenced
this pull request
Jun 29, 2017
forki
added a commit
that referenced
this pull request
Jun 29, 2017
forki
added a commit
that referenced
this pull request
Jun 29, 2017
forki
added a commit
that referenced
this pull request
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original pull request was indeed too intrusive: I wasn't aware that this will lead to an runtime error, if stdout/stderr is a terminal.
This is a revised version of commit 2d63a45,
which broke external processes when standard error/output is not redirected: Refs #1213
This commit only sets the encoding when output is redirected.