Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NUnit3 --params parameter #1532

Merged
merged 1 commit into from
Apr 27, 2017

Conversation

lefthandedgoat
Copy link
Contributor

No description provided.

@lefthandedgoat
Copy link
Contributor Author

This fixes #1493

@matthid
Copy link
Member

matthid commented Apr 27, 2017

Can you try to send the PR on top of my matthid:coreclr branch? This would make sure your changes are not lost in the new netcore release (and you could use them right away from the AppVeyor nuget feed (https://ci.appveyor.com/nuget/fake). If you need help, let me know.

Thanks!

@lefthandedgoat
Copy link
Contributor Author

@matthid I pulled your coreclr branch into my branch and I tried to build but it always get stuck.

These are the last lines before it gets stuck:

  Fake.DotNet.Testing.NUnit -> /Users/cholt1/projects/FAKE/src/app/Fake.DotNet.Testing.NUnit/bin/Release/netstandard1.6/Fake.DotNet.Testing.NUnit.dll
  0 seconds - ready.
  Successfully created package '/Users/cholt1/projects/FAKE/nuget/dotnetcore/Fake.DotNet.Testing.XUnit2.5.0.0-alpha004.nupkg'.
  Paket version 4.8.4
  0 seconds - ready.
  Successfully created package '/Users/cholt1/projects/FAKE/nuget/dotnetcore/Fake.DotNet.Testing.NUnit.5.0.0-alpha004.nupkg'.

I am using OSX and I dont even know if I have the latest .net core installed etc.

I also saw that the file I changed is marked as deprecated. I am happy to make the change in the new file also, but I can't build =.

@matthid
Copy link
Member

matthid commented Apr 27, 2017

@lefthandedgoat oh... I think its enough to ignore that (for now) and just add your changes to the new file. If you open the solution you will see a folder like Fake.DotNet.Testing.NUnit in FakeLib that's where the new stuff is. No .net core is required. If it doesn't compile for .net core (you changes don't looke like it) I'll handle that.

@forki
Copy link
Member

forki commented Apr 27, 2017

thx

@forki forki merged commit 194c7e5 into fsprojects:master Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants