Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.3.1 #2045

Merged
merged 22 commits into from
Aug 5, 2018
Merged

Release 5.3.1 #2045

merged 22 commits into from
Aug 5, 2018

Conversation

matthid
Copy link
Member

@matthid matthid commented Jul 30, 2018

No description provided.

@matthid
Copy link
Member Author

matthid commented Aug 2, 2018

image

SemVer is missing

@kblohm
Copy link
Contributor

kblohm commented Aug 5, 2018

My first idea was also to change the version inside the script, but i dont think it is needed unless you want to always install pre-releases.
I just tested installing the global tool without the --version parameter and that does install 5.3.0.
You can not leave the version blank for the DotNetCliToolReference, but as far as i can tell, using a * here also resolves to 5.3.0.

Just gotta love nuget and their lowest-version policy ;).

@matthid
Copy link
Member Author

matthid commented Aug 5, 2018

  • here also resolves to 5.3.0.

apparently * resolves to 5.0.0 as well... what a mess. What is wildcard even good for...

@matthid matthid changed the title Next Release Release 5.3.1 Aug 5, 2018
@kblohm
Copy link
Contributor

kblohm commented Aug 5, 2018

Are you sure it does?
If i specify <DotNetCliToolReference Include="dotnet-fake" Version="5.0.0" /> and then run

dotnet fake --version

in that folder, i get a 5.0.0.
If i change that to * i get 5.3.0.

@matthid
Copy link
Member Author

matthid commented Aug 5, 2018

@kblohm I meant dotnet tool install --version *, yes CliToolReference seems to behave kind of reasonable

@kblohm
Copy link
Contributor

kblohm commented Aug 5, 2018

For the global tool, just do not specify a --version at all. Thats what i meant for the global one.

@kblohm
Copy link
Contributor

kblohm commented Aug 5, 2018

Also very nice that both of these behave differently xD

@matthid
Copy link
Member Author

matthid commented Aug 5, 2018

Welcome to the world of nuget.

Yes my "fix" is still kind of broken, if we want to install latest....

@kblohm
Copy link
Contributor

kblohm commented Aug 5, 2018

If you want, i can change the template to only add the version when it is specified and use
<DotNetCliToolReference Include="dotnet-fake" Version="*" /> / not add the --version otherwise.

@matthid
Copy link
Member Author

matthid commented Aug 5, 2018

I'm not really familiar with the template thing and how to switch between given and not-given version flag. Additionally, CliToolReference is basically obsolete already

@kblohm
Copy link
Contributor

kblohm commented Aug 5, 2018

Well i would say it is obsolete when they have a solution to properly install the global tools for projects.
If you have a minute, you can look at #2055.

@matthid matthid merged commit 46ffffb into master Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants