Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URGENT: Correct publish artifact #2147

Merged
merged 1 commit into from
Oct 12, 2018
Merged

URGENT: Correct publish artifact #2147

merged 1 commit into from
Oct 12, 2018

Conversation

BlythMeister
Copy link
Contributor

image

@matthid
Copy link
Member

matthid commented Oct 12, 2018

Now you know why I'm so hesitant to accept prs around this area, problem is we have ne easy way to test this stuff...

@BlythMeister
Copy link
Contributor Author

Yeah, true story!

@matthid
Copy link
Member

matthid commented Oct 12, 2018

any idea how to catch errors like this before production are welcome. feel free to add integration tests, note that release/next branch runs on TeamCity as we have a sponsored ci..

@BlythMeister
Copy link
Contributor Author

Not really sure, I only noticed because my files were not in TeamCity...not sure how to script that check.

@matthid
Copy link
Member

matthid commented Oct 12, 2018

While it is red it looks reasonably simple...

@matthid matthid merged commit 4e7a30d into fsprojects:release/next Oct 12, 2018
@matthid
Copy link
Member

matthid commented Oct 12, 2018

Thanks!

@matthid matthid mentioned this pull request Oct 12, 2018
Merged
@BlythMeister BlythMeister deleted the patch-5 branch May 11, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BlythMeister @matthid