Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix perf of Fake.Core.Target #2156

Merged
merged 5 commits into from
Oct 14, 2018
Merged

Fix perf of Fake.Core.Target #2156

merged 5 commits into from
Oct 14, 2018

Conversation

matthid
Copy link
Member

@matthid matthid commented Oct 13, 2018 •
edited
Loading

fixes #2036

@matthid
Start to fix some perf problems, references #2036
5de5378
@matthid
cleanup
2f9fd27
@matthid
Fix Fake.Core.Target performance
a51edf2 
* Fixes various Stackoverflows by making stuff tail recursive
* fix traverse algorithms by using visited hashsets
* Make sure to skip duplicated dependencies
* Other improvements seen in the profiler (ie String.Equals instead of toLower)

Fixes #2036
@matthid matthid changed the title Start to fix some perf problems, references https://github.com/fsharp… Fix perf of Fake.Core.Target Oct 14, 2018
@matthid matthid merged commit 4918b29 into release/next Oct 14, 2018
@matthid matthid deleted the fix_targets_perf branch November 10, 2018 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PERF] large number of duplicated hard/soft references kills the algorithm
1 participant
@matthid