Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword documentation for Fake.Core.StreamSpecification.UseStream #2222

Conversation

theimowski
Copy link
Member

Description

It was a bit misleading, so trying to be a bit clear here.
Please correct me if I misunderstood the requirements for UseStream.

It was a bit misleading, so trying to be a bit clear here.
Please correct me if I misunderstood the purpose.
Copy link
Member

@matthid matthid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more correct would probably be 'writable' and 'readable'. they don't need to be 'write-only' afaik

@theimowski
Copy link
Member Author

Right, after quick glance at the code it seems to be the case indeed - corrected

@matthid matthid merged commit bbbae03 into fsprojects:release/next Dec 18, 2018
@matthid
Copy link
Member

matthid commented Dec 18, 2018

Thanks for fixing this :)

@theimowski theimowski deleted the create_process_use_stream_docs_amends branch December 18, 2018 12:05
@matthid matthid mentioned this pull request Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants