Added Organization field for SonarQube tester #2358
Conversation
|
build failed 😢 |
|
I manually triggered it again and it went green: https://dev.azure.com/fakebuild/FSProjects/_build/results?buildId=1170 |
| @@ -48,7 +55,7 @@ module Fake.Testing.SonarQube | |||
|
|
|||
| let args = | |||
| match call with | |||
| | Begin -> "begin /k:\"" + parameters.Key + "\" /n:\"" + parameters.Name + "\" /v:\"" + parameters.Version + "\" " + setArgs + cfgArgs | |||
| | Begin -> "begin /k:\"" + parameters.Key + "\" /n:\"" + parameters.Name + "\" /v:\"" + parameters.Version + "\" " + setArgs + cfgArgs + orgArgs | |||
There was a problem hiding this comment.
Ideally we would use the Arguments-API instead of string concatenation. Other modules like DotNet.Cli already use it. It also eases writing tests without actually starting anything.
Any interest in pushing this into that direction? The docs are here: https://fake.build/core-process.html
|
I can do this :). Just went on vacation so let's say next week I can do it. |
|
I tried to make it work with the arguments API but I had problems and ill try to explain by trying to explain out most command line interfaces work. Most CLIs have a pretty industry standard CLI that goes:
Now with SonarQube it looks more like this
now it is possible to accomodate for this with the arguments API but there are some commands in the SonarQube CLI that fail to validate if you do not surround the argument in quotes. So theres a second requirement that we need to accomodate for and that is
The problem with the last one is that the Arguments api strips quotes from the strings that you provide it. When I supply the right arguments to SonarQube CLI it bombs since the arguments have been stripped of these important quotes. I hope I am not being crazy here but I think I have tried everything and that seems to be how it works. And my assumptions are confirmed by how the current string appending implementation works on the current version of this package. |
|
Nice analysis, yes there are unfortunately some windows tool, which do some strange argument parsing like this. In theory it shouldn't matter if you put quotes or don't (when no space is in the arguments). Therefore the argument parser 'simplifies' expressions. There is a workaround which allows to provide a raw string unmodified. However, this basically makes the arguments api unusable for this module. So for testing we can only generate the raw string and compare that one and maybe use some primitives for escaping. Sorry, I didn't expect sonar to be of this kind, this usually hits older windows software... |
|
No problem, I still learned a lot so for me its not like it was time wasted. So how do you want to proceed? Should we use my previous commit that works but doesn't leave the codebase in a better condition or is there another way around this? |
|
I probably will take a look eventually, because we need a good way to handle this as well. But it could take a while :/ |
Description
This PR adds the ability to supply the organization argument to the sonarqube scanner. This is important when sending the sonarscanner results to sonarcloud.io