Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting Fixie Module to FAKE 5 #2582

Merged

Conversation

yazeedobaid
Copy link
Collaborator

Description

This PR ports the Fixie module to FAKE 5. The Fixie test runner usage has changed from depending on a Fixie.Console.exe file to run tests to a dotnet fixie command. The following is a sample usage for Fixie test runner using the latest version of Fixie (Fixie V2):

open Fake.Core
open Fake.Testing

Target.create "Fixie" (fun _ ->
Fixie.Fixie (fun p -> { p with Configuration = "Release"l CustomArguments = ["custom","1"; "test","2"] })
)

Target.runOrDefault "Fixie"

The new module uses FAKE DotNet to call dotnet to run the Fixie runner within the context of a test project. The above target will be translated to the following command:

[path-to-dotnet] fixie --configuration Release -- --custom 1 --custom 2

As specified in the Fixie runner docs, this PR adds support for all the arguments used by the runner.

TODO

Feel free to open the PR and ask for help

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)
  • unit or integration test exists (or short reasoning why it doesn't make sense)
  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)
  • (if new module) the module has been linked from the "Modules" menu, edit help/templates/template.cshtml, linking to the API-reference is fine.
  • (if new module) the module is in the correct namespace
  • (if new module) the module is added to Fake.sln (dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)
  • Fake 5 API guideline is honored

@matthid matthid merged commit 8bd3485 into fsprojects:release/next Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants