Roundhouse Cleanup #550
Merged
Roundhouse Cleanup #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…now, and string values are quoted to prevent errant spaces from messing up argument parsing
|
cool. released in 3.5.6 |
|
You are scarily quick sometimes. |
|
Nice work @baronfel 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request cleans up some of the command line calls generated by the roundhouse helper. String values get quoted now, and args that have not been specified are no longer passed to the command line.
Further down the road, I'd like to unify some of the command-line arg creation stuff in the various helpers by using UnionArgParser some more, because as it stands now the MSBuild and Roundhouse helpers have these huge methods that are mostly boilerplate.