-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use fsianycpu.exe instead of fsi.exe. #582
Conversation
we tried 64bit, but it breaks so many existing build scripts because of registry, COM and many other fuckups. But maybe we can create a second nuget package. |
Shall we prepare a nuget Package, or will you do this? Tobias On 03.11.2014, at 16:57, Steffen Forkmann notifications@github.com wrote:
|
I always wanted to do this, but didn't find the time. |
if fi.Exists then fi.FullName else | ||
findPath "FSIPath" FSIPath "fsi.exe" | ||
findPath "FSIPath" FSIPath "fsianycpu.exe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should fall back if the fsianycpu can't be found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As fsi.exe lies at the same place as fsianycpu.exe, what would be the fall back? On the other hand just using the old line containing "fsi.exe" would be fine because of the same reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this one is actually a separate process. But it's not used in the normal
FAKE process.
On Nov 4, 2014 10:39 AM, "tkesselring" notifications@github.com wrote:
In src/app/FakeLib/FSIHelper.fs:
if fi.Exists then fi.FullName else
findPath "FSIPath" FSIPath "fsi.exe"
findPath "FSIPath" FSIPath "fsianycpu.exe"
As fsi.exe lies at the same place as fsianycpu.exe, what would be the fall
back? On the other hand just using the old line containing "fsi.exe" would
be fine because of the same reason.—
Reply to this email directly or view it on GitHub
https://github.com/fsharp/FAKE/pull/582/files#r19792615.
At the end it seems, only the change of the bitness of the Fake-Project had impact. |
I modified the build script s.t. it creates a second nuget package which is any cpu. |
nice. will try in ca. 2 days since im out of office. |
707a93c
to
b688795
Compare
this looks cool. Is it ready to merge? |
I think yes, it worked for me locally. |
use fsianycpu.exe instead of fsi.exe.
files | ||
|> Seq.iter (fun file -> | ||
let args = | ||
{ Program = "lib" @@ "corflags.exe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be helpful in a separate FAKE helper
ok we're generating way to many x64 packages. |
it's released with 3.9. - can you verify that it works? |
"ok we're generating way to many x64 packages. |
I checked it out. Works wonderful for my Project. thx. |
good point |
now it works for us again. But I assume I broke yours. So what should we do? |
I think I made the 32bit-version anycpu and the 64bit-version 32-bit. |
We would like to use Fake also as a 64 bit application.