Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize archive helpers #727

Merged
merged 4 commits into from
Apr 7, 2015

Conversation

neoeinstein
Copy link
Contributor

Provide a more comprehensive suite of archive and compression helpers, including zip, gzip, bzip2, tar, and tar.gz/tar.bz2.

This module isn't AutoOpen, and should be considered as a general case replacement for the ZipHelper module (which is AutoOpen). The modules in ArchiveHelper could be expanded to support some of the use cases provided in ZipHelper, but this is a good base from which to start.

Note that this will fail to build documentation until #719 is resolved. (.\build GenerateDocs fails)

@forki
Copy link
Member

forki commented Apr 2, 2015

cool.

is it possible to let the ziphelper call these functions?

@neoeinstein
Copy link
Contributor Author

I can modify ZipHelper to delegate to these functions. I'll make sure all the PascalCased functions do the right delegation. Do we particularly care about keeping the camelCased functions, or are these generally considered open to removal? Correction. The camelCased functions in ZipHelper are private, so they can be removed without worrying about breaking anyone.

@neoeinstein
Copy link
Contributor Author

With these changes, would there be any interest in marking ZipHelper as Obsolete, encouraging people to move over to the analogues in ArchiveHelper without breaking existing consumers?

@forki
Copy link
Member

forki commented Apr 7, 2015

thanks. for adding this.

forki added a commit that referenced this pull request Apr 7, 2015
@forki forki merged commit 09ccd03 into fsprojects:master Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants