Add support for builds within Team Foundation Server (and VSO). #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
added a commit
that referenced
this pull request
Aug 24, 2015
Add support for builds within Team Foundation Server (and VSO).
|
LGTM since everything is only for TFS |
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BuildServerHelper.fschanges are simply the build server detection.The changes in the
Information.fsshould probably be discussed:The problem is that TF creates a copy of the repository without the
.gitfolder. Therefore we cannot use anygitcommands. I tried to use the information provided by TF to fill some gaps.Maybe some kind of fallback behavior would be more robust? But first I want to here your opinion on this "kind of magic" first.