RegistryHelper #976
Merged
RegistryHelper #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. deleteRegistrySubKey 2. getRegistryValueNames 3. getRegistrySubKeyNames - The function valueExistsForKey now uses getRegistryValueNames
|
thx. can you send another PR for the additional fixes? But please keep API backwards compatible. |
|
You're welcome, @forki. As for the API-changing fix, I still think it would make sense to change the signature of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some additional registry function, as per #966.
I think the function
createRegistrySubKeyshould be changed to follow the pattern of the other ones, but I didn't want to change the API without consulting.It should:
usethe key, since it's an IDisposablebaseKey,subKeyandkeyName.Additional cleanup should include renaming
keyNametovalueNameorvalueinsetRegistryValueanddeleteRegistryValue.