Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change module TaskSeq -> type TaskSeq for extension members #186

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

abelbraaksma
Copy link
Member

@abelbraaksma abelbraaksma commented Oct 30, 2023

This is in preparation of #184 and #133.

While this is technically binary incompatible, for all intents and purposes, existing code would just remain working "as is".

Note that I deliberately chose to stick with the pascalCase convention over the conventions used by F# on the Async methods. That's in part because we already started along that route (we would like to remain backwards compatible), and because it resembles the look and feel of module functions of Seq.

@abelbraaksma abelbraaksma force-pushed the move-to-static-members branch from e36d55a to 2249c64 Compare October 31, 2023 11:13
@abelbraaksma
Copy link
Member Author

Time to merge this one to open the door for the coming-up stuff :).

@abelbraaksma abelbraaksma merged commit 6d121f0 into main Oct 31, 2023
6 checks passed
@abelbraaksma abelbraaksma deleted the move-to-static-members branch October 31, 2023 11:54
@abelbraaksma abelbraaksma added enhancement New feature or request refactoring Cleanup, refactoring and minor fixes compatibility Related to backward or forwards, or F# Core or .NET version compatibility labels Oct 31, 2023
@abelbraaksma abelbraaksma added this to the v0.4.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Related to backward or forwards, or F# Core or .NET version compatibility enhancement New feature or request refactoring Cleanup, refactoring and minor fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants