Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run SourceLink step on CI when from a pull request #826

Closed
ovatsus opened this issue May 10, 2015 · 8 comments
Closed

Do not run SourceLink step on CI when from a pull request #826

ovatsus opened this issue May 10, 2015 · 8 comments

Comments

@ovatsus
Copy link

ovatsus commented May 10, 2015

No description provided.

@ovatsus
Copy link
Author

ovatsus commented May 10, 2015

@ctaggart any idea how to do this? On AppVeyor pull requests always fail with a checksum error, but not sure how to detect if running from master or from a pull request

@ctaggart
Copy link
Contributor

Sure, I'll take a look.

@ovatsus
Copy link
Author

ovatsus commented May 10, 2015

Thanks

@ctaggart
Copy link
Contributor

Do you have an example pull request build that I can look at? I'm looking through the list here:
https://ci.appveyor.com/project/ovatsus/fsharp-data/history

@ovatsus
Copy link
Author

ovatsus commented May 10, 2015

https://ci.appveyor.com/project/ovatsus/fsharp-data/build/2.2.1-a1505011909

source linking C:\projects\fsharp-data\src\bin\Release\FSharp.Data.DesignTime.pdb
2 source files do not have matching checksums in the git repository
no checksum match found for C:\projects\fsharp-data\paket-files\fsprojects\FSharp.TypeProviders.StarterPack\src\DebugProvidedTypes.fs
no checksum match found for C:\projects\fsharp-data\paket-files\fsprojects\FSharp.TypeProviders.StarterPack\src\ProvidedTypes.fs
Running build failed.
Error:
System.Exception: 2 source files do not have matching checksums in the git repository
at FSI_0001.SourceLink.GitRepo.VerifyChecksums(GitRepo x, IEnumerable1 files) in C:\projects\fsharp-data\packages\SourceLink.Fake\tools\SourceLink.fsx:line 47 at FSI_0001.Build.clo@156-17.Invoke(Unit unitVar0) in C:\projects\fsharp-data\build.fsx:line 162 at Fake.TargetHelper.runSingleTarget(TargetTemplate1 target) in C:\code\fake\src\app\FakeLib\TargetHelper.fs:line 411

@ctaggart
Copy link
Contributor

You don't need to disable source indexing on pull requests. You need to exclude the paket-files that are downloaded by paket and are not in your git repository.
ctaggart/SourceLink#45

@ctaggart
Copy link
Contributor

It would actually be a good idea to have those two files be source indexed. In that case, you need to commit them to your repo. I think you can have paket put them in another folder if that helps.

@ovatsus
Copy link
Author

ovatsus commented May 10, 2015

Ah, thanks!

@ovatsus ovatsus closed this as completed Jul 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants