Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

Exclude linked files #45

Closed
forki opened this issue Oct 9, 2014 · 7 comments
Closed

Exclude linked files #45

forki opened this issue Oct 9, 2014 · 7 comments
Milestone

Comments

@forki
Copy link
Contributor

forki commented Oct 9, 2014

I try to use http://fsprojects.github.io/Paket/github-dependencies.html#Referencing-a-single-file but SourceLink keeps complaining about wrong checksum. Which is right since the file doesn't exist on this repo. Can you exclude linked files from the check?

@ctaggart
Copy link
Owner

ctaggart commented Oct 9, 2014

Of course. FSharp.Compiler.Service has a good example of excluding files.
https://github.com/fsharp/FSharp.Compiler.Service/blob/master/build.fsx#L93

@forki
Copy link
Contributor Author

forki commented Oct 10, 2014

nice, but I'd argue that all linked files should be excluded by default since they are not there.

@ctaggart
Copy link
Owner

In the case of the FSharp.Compiler.Service project above, the files are indeed in the repository and should be source indexed. In the case of Paket imports, they are not. I added vsproj.CompilesLinked and .CompilesNotLinked. That should make it easy to get an appropriate set of files for many projects. The VerifyPdbChecksums will need the unfiltered list.

@ctaggart ctaggart added this to the 0.5.0 milestone Nov 27, 2014
@forki
Copy link
Contributor Author

forki commented Apr 27, 2015

Mhm it doesn't seem to work. I have https://github.com/fsharp/FAKE/blob/master/src/app/FakeLib/FakeLib.fsproj#L41 but SourceLink is complaining.

@ctaggart
Copy link
Owner

ctaggart commented May 2, 2015

@ctaggart ctaggart reopened this May 2, 2015
@ctaggart
Copy link
Owner

It does work, but the code in your build.fsx was not quite right. For the upcoming 0.6 release, I'll fix #75 and try to come up with an easier API that hopefully mirrors SourceLink.exe. I'll use FAKE as the test case and submit a pull request after it is out.

@ctaggart
Copy link
Owner

I've got this working for FAKE here fsprojects/FAKE#845. I'll finish the WIP when I release 0.6 officially.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants